From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [Patch]8139too: remove unnecessary cast of ioread32()'s return value
Date: Sun, 30 May 2010 19:24:18 -0400 [thread overview]
Message-ID: <4C02F3A2.90100@garzik.org> (raw)
In-Reply-To: <20100530.153451.193700815.davem@davemloft.net>
On 05/30/2010 06:34 PM, David Miller wrote:
> From: Jeff Garzik<jeff@garzik.org>
> Date: Sun, 30 May 2010 13:35:51 -0400
>
>> Have you verified this matches all architectures definition of
>> readl()?
> And if it doesn't match, that's an arch bug which should be fixed and
> in any event there is only one possibility of a non-match and that is
> if the routine returns "unsigned long"
That was the genesis of the question. Some arches still use unsigned long.
Jeff
next prev parent reply other threads:[~2010-05-30 23:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 12:22 [Patch]8139too: remove unnecessary cast of ioread32()'s return value Junchang Wang
2010-05-30 17:35 ` Jeff Garzik
2010-05-30 22:34 ` David Miller
2010-05-30 23:24 ` Jeff Garzik [this message]
2010-05-31 1:29 ` David Miller
2010-05-31 1:35 ` David Miller
2010-06-02 17:52 ` Jeff Garzik
2010-05-31 0:22 ` Junchang Wang
2010-05-31 7:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C02F3A2.90100@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.