From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: exofs_file_fsync
Date: Mon, 31 May 2010 13:23:09 +0300
Message-ID: <4C038E0D.3010400@panasas.com>
References: <20100531100927.GA11149@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from daytona.panasas.com ([67.152.220.89]:42249 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751437Ab0EaKXM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 31 May 2010 06:23:12 -0400
In-Reply-To: <20100531100927.GA11149@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 05/31/2010 01:09 PM, Christoph Hellwig wrote:
> Various odd things going on here:
> 
>  - no checks for I_DIRTY and friends, so it will always write out data
>  - filemap_write_and_wait is superflous, as it's already done by
>    the caller
>  - write_inode_now is overkill as it also writes out data, better use
>    sync_inode in a similar way to generic_file_fsync

I'll look into it, but I think what I did here was to effectively
"data sync" because I wanted a data sync on close and that was the only
vector I already had that's called on close.

I want "data sync on close" because I'm kind of close-2-open
network semantics, cross a network. And this is my local
access checkpoint.

But sure I'll re think the all thing.

Thanks
Boaz