From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Xiaotian Feng <dfeng@redhat.com>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table
Date: Mon, 31 May 2010 16:34:32 +0200 [thread overview]
Message-ID: <4C03C8F8.8050602@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1005311519160.25402@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Monday 2010-05-31 13:51, Jan Engelhardt wrote:
>> On Monday 2010-05-31 13:06, Xiaotian Feng wrote:
>>
>>> In xt_register_table, xt_jumpstack_alloc is called first, later
>>> xt_replace_table is used. But in xt_replace_table, xt_jumpstack_alloc
>>> will be used again. Then the memory allocated by previous xt_jumpstack_alloc
>>> will be leaked. We can simply remove the previous xt_jumpstack_alloc because
>>> there aren't any users of newinfo between xt_jumpstack_alloc and
>>> xt_replace_table.
>> Indeed that seems to be so.
>
> Acked-By: Jan Engelhardt <jengelh@medozas.de>
Applied, thanks everyone.
next prev parent reply other threads:[~2010-05-31 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 11:06 [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table Xiaotian Feng
2010-05-31 11:51 ` Jan Engelhardt
2010-05-31 13:13 ` [PATCH] netfilter: xtables: stackptr should be percpu Eric Dumazet
2010-05-31 13:22 ` Jan Engelhardt
2010-05-31 13:44 ` Eric Dumazet
2010-05-31 13:44 ` Eric Dumazet
2010-05-31 14:09 ` Jan Engelhardt
2010-05-31 14:09 ` Jan Engelhardt
2010-05-31 14:16 ` Eric Dumazet
2010-05-31 14:16 ` Eric Dumazet
2010-05-31 14:37 ` Patrick McHardy
2010-05-31 13:19 ` [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table Jan Engelhardt
2010-05-31 14:34 ` Patrick McHardy [this message]
2010-05-31 14:37 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C03C8F8.8050602@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.