From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42700 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJRDx-0002jk-GS for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJRDw-0006nY-6i for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:09:41 -0400 Received: from goliath.siemens.de ([192.35.17.28]:24254) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJRDv-0006mI-Ud for qemu-devel@nongnu.org; Tue, 01 Jun 2010 09:09:40 -0400 Message-ID: <4C05068E.4010102@siemens.com> Date: Tue, 01 Jun 2010 15:09:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de> <4C021ED5.1080703@redhat.com> <4C038882.3080007@redhat.com> <20100601100434.380c6ab3@redhat.com> In-Reply-To: <20100601100434.380c6ab3@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Juan Quintela , "qemu-devel@nongnu.org" , Markus Armbruster , Blue Swirl , Jan Kiszka , Gerd Hoffmann , Avi Kivity Luiz Capitulino wrote: > Two bugs that might not be related to this thread: > > * "id" member is not mandatory for the device_add command: > > { "execute": "device_add", "arguments": { "driver": "e1000" } } > {"return": {}} Once we enable qtree paths for device_del, this is no longer an issue, devices will remain addressable. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux