From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] [PVOPS] fix gntdev on PAE
Date: Tue, 01 Jun 2010 09:46:45 -0700 [thread overview]
Message-ID: <4C053975.9080906@goop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1006011733490.3401@kaball-desktop>
On 06/01/2010 09:36 AM, Stefano Stabellini wrote:
>>> Performances shouldn't matter in this case.
>>> Something like this:
>>>
>>>
>> The problem is that the rcu lock disables preemption, so anything inside
>> it must be non-scheduling. So it would need to be a spinlock type
>> thing, I think.
>>
> right, in fact rwlock is a rw spinlock if I am not mistaken
>
Ah, yes. The problem with just making it a spinlock is that other parts
of the code do copy_from_user while holding it, so they would need to be
restructured to avoid that.
Also, rwlock is (almost?) never useful compared to a plain spinlock.
J
next prev parent reply other threads:[~2010-06-01 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 15:11 [PATCH] [PVOPS] fix gntdev on PAE Stefano Stabellini
2010-02-01 15:46 ` Stefano Stabellini
2010-02-09 21:57 ` Jeremy Fitzhardinge
2010-02-10 12:19 ` Stefano Stabellini
2010-02-10 23:12 ` Jeremy Fitzhardinge
2010-05-28 17:29 ` Jeremy Fitzhardinge
2010-06-01 9:38 ` Stefano Stabellini
2010-06-01 16:31 ` Jeremy Fitzhardinge
2010-06-01 16:36 ` Stefano Stabellini
2010-06-01 16:46 ` Jeremy Fitzhardinge [this message]
2010-06-02 14:11 ` Stefano Stabellini
2010-06-02 17:11 ` Jeremy Fitzhardinge
2010-06-03 9:32 ` Stefano Stabellini
2010-06-09 19:38 ` Jeremy Fitzhardinge
2010-02-09 22:24 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C053975.9080906@goop.org \
--to=jeremy@goop.org \
--cc=kraxel@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.