From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OJboK-0008LV-Qw for mharc-grub-devel@gnu.org; Tue, 01 Jun 2010 20:27:56 -0400 Received: from [140.186.70.92] (port=37058 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJboI-0008KH-2t for grub-devel@gnu.org; Tue, 01 Jun 2010 20:27:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJboG-0002DF-Pi for grub-devel@gnu.org; Tue, 01 Jun 2010 20:27:53 -0400 Received: from ey-out-1920.google.com ([74.125.78.147]:23968) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJboG-0002Cy-H3 for grub-devel@gnu.org; Tue, 01 Jun 2010 20:27:52 -0400 Received: by ey-out-1920.google.com with SMTP id 13so597130eye.34 for ; Tue, 01 Jun 2010 17:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=lW/6lsXao/E/VCBXNpMQDle6IMzUnBIP/1P4IL0RnR0=; b=R7ehPiEqEIRFCoLuYbZHvPyJ6MQ3qwkaYMMOYQC4f2ted03vAwHCNeE/xFAhUFvLgu VxfXjnuitTyC+84MT8w0ymx5Ldfq+CbeUzZiQKdmggAKGAaFRMwe9bK9lIU5tlc9P0KY eA3AZaVOd5+zHnPolfMFdRAn010m4TzkgpUgw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=rE4TE+PtP+zKA8qn7g8i6aEBgll4KdJutGahFmFWkjmFdpS10Et/nn718a/A1oDFTa Gmc8y2/LU4R9yeF5735b5I8FmJEZFeI+jYIZG2rUvnEZI/De9PA8nfx/56pYRqHyiMbU /pqqz8DBpCUhjcJX2OTAjL6uH1nFwgb6G6DQw= Received: by 10.213.31.203 with SMTP id z11mr4145201ebc.86.1275438470944; Tue, 01 Jun 2010 17:27:50 -0700 (PDT) Received: from debian.bg45.phnet (gprs11.swisscom-mobile.ch [193.247.250.11]) by mx.google.com with ESMTPS id 13sm4083787ewy.1.2010.06.01.17.27.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 01 Jun 2010 17:27:50 -0700 (PDT) Message-ID: <4C05A579.7080106@gmail.com> Date: Wed, 02 Jun 2010 02:27:37 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <1268605383.2839.26.camel@homenes1> <4BB657BB.60801@gmail.com> <1270669741.2732.129.camel@homenes1> <4BBCED68.3080900@gmail.com> <1270762038.2730.37.camel@homenes1> <4BC892C3.3090507@gmail.com> <1271794445.4221.93.camel@pracovna> <1274485618.18038.56.camel@pracovna> <4BF86523.4090509@gmail.com> <1274610426.5231.67.camel@pracovna> <4BF93F58.3080307@gmail.com> <1274634978.6742.13.camel@pracovna> <4BF9839A.2030704@gmail.com> <1274813892.18826.36.camel@pracovna> <1275238274.6704.21.camel@pracovna> <4C02E60A.3060407@gmail.com> <4C03AA29.2020807@gmail.com> <1275342853.4170.133.camel@pracovna> <4C0451C4.90409@gmail.com> <1275426853.4968.64.camel@pracovna> In-Reply-To: <1275426853.4968.64.camel@pracovna> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigF7A20C333F272DC1A1CC3B7B" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [RFT] Re: [Patch] [bug #26237] multiple problems with usb devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2010 00:27:55 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF7A20C333F272DC1A1CC3B7B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/01/2010 11:14 PM, Ale=C5=A1 Nesrsta wrote: > On both HCs was not working device which has max. packet length for > control endpoint lower than 64. As I remember that this patch was > relative simple, I shortly looked into usb.c and usbtrans.c and there i= s > mistake: > > --- usbtrans.c > +++ usbtrans_corrected.c=09 > @@ -76,7 +76,7 @@ > setupdata_addr =3D grub_dma_get_phys (setupdata_chunk); > =20 > /* Determine the maximum packet size. */ > - if (dev->initialized && dev->descdev.maxsize0) > + if (dev->descdev.maxsize0) > max =3D dev->descdev.maxsize0; > else > max =3D 64; > > =20 Thanks, applied. > Why: > dev->initialized is set to TRUE too late (after address setting > transaction) so we have to ignore it in control transfers - we must use= > value from dev->descdev.maxsize0 immediately after successful reading o= f > first 8 bytes of device descriptor (where is this value included) - as > is (probably not clearly, sorry) described by me in this part of usb.c > code: > > =20 Actualy I was confused because I had a similar change in the same place to avoid division by zero. > There is probably some new problem in OHCI because some devices are now= > very slow on this controller. Unfortunately I currently have no time to= > discover why - I am expecting some mistake probably in "toggling" and > related code in ohci.c. > =20 I've managed to recreate it with one of my USB sticks. Investigating. > On UHCI does not work my mobile phone. But I am not 100% sure if it > worked before on UHCI and I have no time to try it now. I am 100% sure > it worked on OHCI - so maybe it is similar problem as with my card > reader. > > And some old (but probably not critical) problem remains in UHCI - ther= e > is still not properly working sequence: > rmmod usbms, rmmod uhci, device>, insmod uhci, insmod usbms > =20 I haven't retried UHCI on my laptop but I think it will fail because BIOS has a bug in EHCI handover. > - it works on OHCI but on UHCI it does not work - for first look it is > working (for example commands "ls" and "ls (usb0,1)" are working if > these commands are used as first commands after device change) but for > second look does not (for example command "ls (usb0,1)/= " > reports USB mass storage stalled). > > Best regards > Ales > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigF7A20C333F272DC1A1CC3B7B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkwFpYAACgkQNak7dOguQgkrXQEAjoSBN29TWuNAhgGLstAHpgqx g1hlXVYTeWdddRWjRfsA/jQBQbkWviw+qxcZ1UZ59Kok046DXk7QYeDvF83nZhiN =PEaL -----END PGP SIGNATURE----- --------------enigF7A20C333F272DC1A1CC3B7B--