From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56176 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OJhs4-0002qT-HB
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:56:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1OJhs3-00084B-KC
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:56:12 -0400
Received: from isrv.corpit.ru ([81.13.33.159]:50858)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1OJhs3-00083o-7n
	for qemu-devel@nongnu.org; Wed, 02 Jun 2010 02:56:11 -0400
Message-ID: <4C060083.4070200@msgid.tls.msk.ru>
Date: Wed, 02 Jun 2010 10:56:03 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: assign a default serial number
	if	none provided
References: <20100602014854.GB16406@us.ibm.com>
In-Reply-To: <20100602014854.GB16406@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: john cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org

02.06.2010 05:48, Ryan Harper wrote:
[]
>   hw/virtio-blk.c |    3 +++
> +    if (strlen(s->sn) == 0) {

Just out of curiocity (not that it is wrong or inefficient):
why
   strlen(s->sn)
and not, say,
   !s->sn[0]
?

/mjt