Re: ACPICA Release 20100528 linuxized patches

[Alexey Starikovskiy <astarikovskiy@suse.de>]

Hi Ming,

02.06.2010 06:13, Lin Ming пишет:
> diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c
> index 38293fd..00a444f 100644
> --- a/drivers/acpi/acpica/exfldio.c
> +++ b/drivers/acpi/acpica/exfldio.c
> @@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,
>  	ACPI_MEMSET(buffer, 0, buffer_length);
>  	access_bit_width = ACPI_MUL_8(obj_desc->common_field.access_byte_width);
>  
> -	/* Handle the simple case here */
> -
> -	if ((obj_desc->common_field.start_field_bit_offset == 0) &&
> -	    (obj_desc->common_field.bit_length == access_bit_width)) {
I would guess we need to zero the whole buffer here... Buffer length is sizeof(ACPI_INTEGER), we read only 8 bits,
everything else is packed with garbage.
> -		status = acpi_ex_field_datum_io(obj_desc, 0, buffer, ACPI_READ);
> -		return_ACPI_STATUS(status);
> -	}
> -
Thanks,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html