All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Brad Jorsch <anomie@users.sourceforge.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible
Date: Wed, 02 Jun 2010 08:30:11 -0500	[thread overview]
Message-ID: <4C065CE3.1090609@codemonkey.ws> (raw)
In-Reply-To: <1272992201-26911-1-git-send-email-anomie@users.sourceforge.net>

On 05/04/2010 11:56 AM, Brad Jorsch wrote:
> The emulated mice should emulate a horizontal wheel when possible. This
> patch series does that for the USB mouse and tablet and the ExPS/2
> mouse. As far as I can tell the vmmouse protocol doesn't handle a
> horizontal wheel, and I have no idea if emulating a wheel might make
> sense for any of the other mouse types.
>    

At this point, are we just talking about adding additional mouse buttons?

I think instead of adding an additional parameter for horizontal wheel, 
we should look at making the API capable of accepting/generating 
arbitrary button presses.

Really, we should just drop dz and treat vertical wheel as two button 
presses within button_state.  Likewise, horizontal wheel should just be 
two additional bits within button_state.

Regards,

Anthony Liguori

> I've tested this using the SDL interface and an Ububtu 10.04 cd image;
> xev reports the correct events for all three devices, and a gedit window
> with sufficient text to create scrollbars scrolls correctly with both
> mice (didn't test the tablet). More testing would be good.
>
> See also Debian bug #579968.[1]
>
> [1] http://bugs.debian.org/579968
>
>
>
>    

  parent reply	other threads:[~2010-06-02 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 16:56 [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible Brad Jorsch
2010-05-04 16:56 ` [Qemu-devel] [PATCH 1/5] Add function parameters for hwheel Brad Jorsch
2010-05-04 16:56 ` [Qemu-devel] [PATCH 2/5] Add hwheel to monitor mouse_move Brad Jorsch
2010-05-04 16:56 ` [Qemu-devel] [PATCH 3/5] Pass hwheel events from the front-ends Brad Jorsch
2010-05-04 16:56 ` [Qemu-devel] [PATCH 4/5] Add a horizontal wheel to the USB mouse and tablet Brad Jorsch
2010-05-04 16:56 ` [Qemu-devel] [PATCH 5/5] Add a horizontal wheel to the exps/2 mouse Brad Jorsch
2010-06-02 13:30 ` Anthony Liguori [this message]
2010-06-02 16:14   ` [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible Brad Jorsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C065CE3.1090609@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=anomie@users.sourceforge.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.