From: Richard Henderson <rth@twiddle.net>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Unposted reserved_va patch
Date: Wed, 02 Jun 2010 10:20:50 -0700 [thread overview]
Message-ID: <4C0692F2.9060203@twiddle.net> (raw)
Re: 68a1c816868b3e35a1da698af412b29e61b1948a
In general, I like the idea (especially since I've proposed it before. ;-)
However:
+ if (have_guest_base) {
+ flags |= MAP_FIXED;
+ }
I think this is broken. If the user specifies -G n -R m they're hoping
or guessing that the range [n,n+m) is free. What they're not expecting
is for the qemu application or any of the required shared libraries to
get forcibly unmapped.
I think instead you should simply adjust the error reporting after the
mmap attempt without MAP_FIXED.
r~
next reply other threads:[~2010-06-02 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 17:20 Richard Henderson [this message]
2010-06-03 4:54 ` [Qemu-devel] Re: Unposted reserved_va patch Paul Brook
2010-06-03 14:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0692F2.9060203@twiddle.net \
--to=rth@twiddle.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.