From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"Cengiz Günay" <cgunay@emory.edu>,
stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_nv: don't diddle with nIEN on mcp55
Date: Wed, 02 Jun 2010 13:51:14 -0400 [thread overview]
Message-ID: <4C069A12.4090602@garzik.org> (raw)
In-Reply-To: <4C052751.3070403@kernel.org>
On 06/01/2010 11:29 AM, Tejun Heo wrote:
> On mcp55, nIEN gets stuck once set and liteon blueray rom iHOS104-08
> violates ATA specification and fails to set I on D2H Reg FIS if nIEN
> is set when the command was issued. When the other party is following
> the spec, both devices can work fine but when the two flaws are put
> together, they can't talk to each other.
>
> mcp55 has its own IRQ masking mechanism and there's no reason to mess
> with nIEN in the first place. Fix it by dropping nIEN diddling from
> nv_mcp55_freeze/thaw().
>
> This was originally reported by Cengiz. Although Cengiz hasn't
> verified the fix yet, I could reproduce this problem and verfiy the
> fix. Even if Cengiz is experiencing different or additional problems,
> this patch is needed.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Cengiz Günay<cgunay@emory.edu>
> Cc: stable@kernel.org
> ---
> drivers/ata/sata_nv.c | 2 --
applied
prev parent reply other threads:[~2010-06-02 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:29 [PATCH #upstream-fixes] sata_nv: don't diddle with nIEN on mcp55 Tejun Heo
2010-06-02 17:51 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C069A12.4090602@garzik.org \
--to=jeff@garzik.org \
--cc=cgunay@emory.edu \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.