From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frieder Ferlemann <frieder.ferlemann@web.de>
Subject: Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors
	(v3)
Date: Wed, 02 Jun 2010 23:46:51 +0200
Message-ID: <4C06D14B.9050505@web.de>
References: <AANLkTinAiLb1LFBxWL7Ck61B3K8AcFkr-mP0WaOUgpGV@mail.gmail.com>
	<1275497985-22866-1-git-send-email-alexdeucher@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from fmmailgate02.web.de (fmmailgate02.web.de [217.72.192.227])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6C2669EEB5
	for <dri-devel@lists.freedesktop.org>;
	Wed,  2 Jun 2010 14:46:53 -0700 (PDT)
Received: from smtp07.web.de  ( [172.20.5.215])
	by fmmailgate02.web.de (Postfix) with ESMTP id 24E5016495ABF
	for <dri-devel@lists.freedesktop.org>;
	Wed,  2 Jun 2010 23:46:52 +0200 (CEST)
Received: from [95.117.255.163] (helo=[192.168.1.73])
	by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #4)
	id 1OJvm0-000470-00
	for dri-devel@lists.freedesktop.org; Wed, 02 Jun 2010 23:46:52 +0200
In-Reply-To: <1275497985-22866-1-git-send-email-alexdeucher@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi,

Am 02.06.2010 18:59, schrieb Alex Deucher:
> +/* get temperature in millidegrees */
> +u32 evergreen_get_temp(struct radeon_device *rdev)

Could it be named evergreen_get_temp_mcelsius_clipped_to_above_zero ?^)


Seriously: would it make sense to have:
u32 evergreen_get_temp_mkelvin(struct radeon_device *rdev)


With all that it implies? Just that it's there?)


Greetings,
Frieder