[Qemu-devel] Re: [PATCH 2/3] qemu-thread: add cleanup_push() and cleanup_pop()

[Paolo Bonzini <pbonzini@redhat.com>]

On 05/29/2010 09:38 AM, Corentin Chary wrote:
> Signed-off-by: Corentin Chary<corentincj@iksaif.net>
> ---
>   qemu-thread.h |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-thread.h b/qemu-thread.h
> index 19bb30c..e5006bb 100644
> --- a/qemu-thread.h
> +++ b/qemu-thread.h
> @@ -41,4 +41,8 @@ void qemu_thread_self(QemuThread *thread);
>   int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2);
>   void qemu_thread_exit(void *retval);
>
> +#define qemu_thread_cleanup_pop(execute) pthread_cleanup_pop(execute)
> +#define qemu_thread_cleanup_push(routine, arg)  \
> +    pthread_cleanup_push(routine, arg)

I agree with Paul that this isn't necessary.  Also you're not using 
pthread_exit.  Probably stale from a previous version of the patch?

Paolo