From: Clemens Ladisch <clemens@ladisch.de>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: Bert dd <bert.ddecker@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Is there a way to change irq numbers of pcie cards ?
Date: Thu, 03 Jun 2010 09:43:20 +0200 [thread overview]
Message-ID: <4C075D18.8010108@ladisch.de> (raw)
In-Reply-To: <4C06E59E.40508@gmail.com>
Robert Hancock wrote:
> On 06/02/2010 06:08 AM, Bert dd wrote:
> > I have a supermicro machine with 2 raid cards (lsi 9260-8i and lsi 9260-8e) and
> > one nvidia GTX480 graphics card.
> > The problem is that all these pcie cards are assigned the same irq number,
>
> If you can get MSI enabled for some of those cards, though, that should
> prevent them from sharing interrupts.
The PCIe spec says that all PCIe devices must support MSI interrupts.
(Whether they do in practice is another question ...)
Regardless of the graphics card, enabling MSI for the RAID cards will
prevent their interrupts from interfering with each other.
Bert, you might want to try this completely untested patch:
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -3169,6 +3169,8 @@ megasas_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
if (megasas_init_mfi(instance))
goto fail_init_mfi;
+ pci_enable_msi(pdev);
+
/*
* Register IRQ
*/
@@ -3218,6 +3220,7 @@ megasas_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
pci_set_drvdata(pdev, NULL);
instance->instancet->disable_intr(instance->reg_set);
free_irq(instance->pdev->irq, instance);
+ pci_disable_msi(pdev);
megasas_release_mfi(instance);
@@ -3354,6 +3357,7 @@ megasas_suspend(struct pci_dev *pdev, pm_message_t state)
pci_set_drvdata(instance->pdev, instance);
instance->instancet->disable_intr(instance->reg_set);
free_irq(instance->pdev->irq, instance);
+ pci_disable_msi(pdev);
pci_save_state(pdev);
pci_disable_device(pdev);
@@ -3416,6 +3420,8 @@ megasas_resume(struct pci_dev *pdev)
tasklet_init(&instance->isr_tasklet, megasas_complete_cmd_dpc,
(unsigned long)instance);
+ pci_enable_msi(pdev);
+
/*
* Register IRQ
*/
@@ -3519,6 +3525,7 @@ static void __devexit megasas_detach_one(struct pci_dev *pdev)
instance->instancet->disable_intr(instance->reg_set);
free_irq(instance->pdev->irq, instance);
+ pci_disable_msi(pdev);
megasas_release_mfi(instance);
prev parent reply other threads:[~2010-06-03 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 12:08 Is there a way to change irq numbers of pcie cards ? Bert dd
2010-06-02 19:19 ` Bjorn Helgaas
2010-06-02 23:13 ` Robert Hancock
2010-06-03 7:43 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C075D18.8010108@ladisch.de \
--to=clemens@ladisch.de \
--cc=bert.ddecker@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.