From: Paolo Bonzini <pbonzini@redhat.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Qemu-development List <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: [Qemu-devel] Re: [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks
Date: Thu, 03 Jun 2010 14:37:45 +0200 [thread overview]
Message-ID: <4C07A219.8090801@redhat.com> (raw)
In-Reply-To: <AANLkTimDnj5S1lga0dPVup9ir8tMGhtPZVJXu2JZVdt6@mail.gmail.com>
On 06/03/2010 01:41 PM, Corentin Chary wrote:
>> + if (sigprocmask(SIG_SETMASK,&set,&oldset)) {
>> + async_abort(errno, "sigprocmask");
>> + }
>> +
>> + qemu_thread_create_attr(&thread,&attr, async_worker_thread, queue);
>> +
>> + if (sigprocmask(SIG_SETMASK,&oldset, NULL)) {
>> + async_abort(errno, "sigprocmask restore");
>> + }
I wonder if qemu_thread_create shouldn't block all signals by default.
Then the cpu and iothreads can unblock whatever they want.
I'll send a patch shortly.
In any case, please use pthread_sigmask instead of sigprocmask.
Paolo
next prev parent reply other threads:[~2010-06-03 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 8:56 [Qemu-devel] [PATCH V3 0/3] qemu: Make AIO threading framework generic Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 1/3] qemu: Add qemu-wrappers for pthread_attr_t Gautham R Shenoy
2010-06-03 12:31 ` [Qemu-devel] " Paolo Bonzini
2010-06-04 13:07 ` Anthony Liguori
2010-06-04 13:19 ` Corentin Chary
2010-06-04 13:27 ` Paolo Bonzini
2010-06-10 11:12 ` Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks Gautham R Shenoy
2010-06-03 11:41 ` [Qemu-devel] " Corentin Chary
2010-06-03 12:37 ` Paolo Bonzini [this message]
2010-06-04 13:16 ` [Qemu-devel] " Anthony Liguori
2010-06-05 7:03 ` Corentin Chary
2010-06-10 11:37 ` Gautham R Shenoy
2010-06-03 8:56 ` [Qemu-devel] [PATCH V3 3/3] qemu: Convert AIO code to use the generic threading infrastructure Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C07A219.8090801@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=corentin.chary@gmail.com \
--cc=ego@in.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.