All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yanhai <yanhai.zhu@linux.intel.com>
To: Zhu Yanhai <yanhai.zhu@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] gateway_server_remove should unref audio_adapter
Date: Fri, 04 Jun 2010 16:25:14 +0800	[thread overview]
Message-ID: <4C08B86A.70602@linux.intel.com> (raw)
In-Reply-To: <1275639598-22048-1-git-send-email-yanhai.zhu@linux.intel.com>

On 06/04/2010 04:19 PM, Zhu Yanhai wrote:
> gateway_server_remove should unrefer the adapter, not refer it.
>
> Signed-off-by: Zhu Yanhai<yanhai.zhu@linux.intel.com>
> ---
>   audio/manager.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/manager.c b/audio/manager.c
> index 28fd8af..f6a98cd 100644
> --- a/audio/manager.c
> +++ b/audio/manager.c
> @@ -932,7 +932,7 @@ static void gateway_server_remove(struct btd_adapter *adapter)
>   		adp->hfp_hs_server = NULL;
>   	}
>
> -	audio_adapter_ref(adp);
> +	audio_adapter_unref(adp);
>   }
>
>   static int a2dp_server_probe(struct btd_adapter *adapter)

The current BlueZ 4.65 can't register itself on DBUS after system 
resume, as the interface org.bluez.Adapter wasn't unregistered during 
system suspend due to the non-zero ref numbers.

Regards,
Zhu Yanhai

  reply	other threads:[~2010-06-04  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  8:19 [PATCH] gateway_server_remove should unref audio_adapter Zhu Yanhai
2010-06-04  8:25 ` Zhu Yanhai [this message]
2010-06-04  8:30 ` Johan Hedberg
2010-06-04  8:40   ` Zhu Yanhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C08B86A.70602@linux.intel.com \
    --to=yanhai.zhu@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.