All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add exit notifiers.
Date: Fri, 04 Jun 2010 14:10:53 +0200	[thread overview]
Message-ID: <4C08ED4D.80600@redhat.com> (raw)
In-Reply-To: <AANLkTilfa2xQSav4bP0VeuFBvlfYI-BOAsWKXW0gPNc5@mail.gmail.com>

>> --- a/roms/seabios
>> +++ b/roms/seabios
>> @@ -1 +1 @@
>> -Subproject commit 8f469b9676127ba6bb52609d89ec774e61db0ee1
>> +Subproject commit 7d09d0e3ba11310e973d4302c7fcc3fc2184e04c
>
> This hunk seems unrelated to your commit.

Damn.  Yea.  These seem to creap in now and then, I think when rebasing 
to a new version with new seabios, then carelessly doing 'git commit -a'.

>> +void qemu_add_exit_notifier(Notifier *notify)
>
> Why #ifndef _WIN32?  I think this patch will break _WIN32 builds.

Not intentionally.  Sent fixed version.

cheers,
   Gerd

  reply	other threads:[~2010-06-04 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  9:35 [Qemu-devel] [PATCH] Add exit notifiers Gerd Hoffmann
2010-06-04 10:14 ` Stefan Hajnoczi
2010-06-04 12:10   ` Gerd Hoffmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-06-04 12:08 Gerd Hoffmann
2010-06-14 20:57 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C08ED4D.80600@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.