From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: ARM: Fix kernel panic caused by unaligned access in sata_sil24 Date: Fri, 04 Jun 2010 15:23:50 +0200 Message-ID: <4C08FE66.9000306@kernel.org> References: <000301cb03e2$bf0020e0$3d0062a0$@tuckley@arm.com> <4C08FE27.1050109@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:60395 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755213Ab0FDNX4 (ORCPT ); Fri, 4 Jun 2010 09:23:56 -0400 In-Reply-To: <4C08FE27.1050109@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Colin Tuckley Cc: linux-ide@vger.kernel.org, Catalin Marinas , Robin Randhawa On 06/04/2010 03:22 PM, Tejun Heo wrote: > On 06/04/2010 02:37 PM, Colin Tuckley wrote: >> From: Colin Tuckley >> >> Subject: ARM: Fix kernel panic caused by unaligned access in sata_sil24 >> >> The sata_sil24 driver has six 16-bit registers that are initialised with >> 32-bit writes. This cause a kernel panic on ARM due to the unaligned >> accesses which result. >> >> This patch changes the accesses to the correct 16-bit ones. >> >> Signed-off-by: Colin Tuckley > > Acked-by: Tejun Heo Oh, but please add Jeff Garzik and add sata_sil24: prefix to the subject. Thanks. -- tejun