From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35981 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OKbJK-0005xA-5B
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:08:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OKbCu-0006xz-5E
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:01:25 -0400
Received: from are.twiddle.net ([75.149.56.221]:55898)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OKbCt-0006xl-I9
	for qemu-devel@nongnu.org; Fri, 04 Jun 2010 14:01:24 -0400
Message-ID: <4C093F6F.5070404@twiddle.net>
Date: Fri, 04 Jun 2010 11:01:19 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 04/10] target-mips: refactor {c, abs}.cond.fmt
	insns
References: <1274717984-25887-1-git-send-email-froydnj@codesourcery.com>
	<1274717984-25887-5-git-send-email-froydnj@codesourcery.com>
In-Reply-To: <1274717984-25887-5-git-send-email-froydnj@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 05/24/2010 09:19 AM, Nathan Froyd wrote:
> +    case FMT_D:                                                               \
> +        if (abs)                                                              \
> +            check_cop1x(ctx);                                                 \
> +        check_cp1_registers(ctx, fs | ft);                                    \
> +        break;                                                                \
> +    case FMT_S:                                                               \
> +        if (abs)                                                              \
> +            check_cop1x(ctx);                                                 \

Coding style.

> +    switch (n) {                                                              \
> +    case  0: gen_helper_2i(cmp ## type ## _ ## fmt ## _f, fp0, fp1, cc);    break;\
> +    case  1: gen_helper_2i(cmp ## type ## _ ## fmt ## _un, fp0, fp1, cc);   break;\
> +    case  2: gen_helper_2i(cmp ## type ## _ ## fmt ## _eq, fp0, fp1, cc);   break;\
> +    case  3: gen_helper_2i(cmp ## type ## _ ## fmt ## _ueq, fp0, fp1, cc);  break;\
> +    case  4: gen_helper_2i(cmp ## type ## _ ## fmt ## _olt, fp0, fp1, cc);  break;\
> +    case  5: gen_helper_2i(cmp ## type ## _ ## fmt ## _ult, fp0, fp1, cc);  break;\
> +    case  6: gen_helper_2i(cmp ## type ## _ ## fmt ## _ole, fp0, fp1, cc);  break;\
> +    case  7: gen_helper_2i(cmp ## type ## _ ## fmt ## _ule, fp0, fp1, cc);  break;\
> +    case  8: gen_helper_2i(cmp ## type ## _ ## fmt ## _sf, fp0, fp1, cc);   break;\
> +    case  9: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngle, fp0, fp1, cc); break;\
> +    case 10: gen_helper_2i(cmp ## type ## _ ## fmt ## _seq, fp0, fp1, cc);  break;\
> +    case 11: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngl, fp0, fp1, cc);  break;\
> +    case 12: gen_helper_2i(cmp ## type ## _ ## fmt ## _lt, fp0, fp1, cc);   break;\
> +    case 13: gen_helper_2i(cmp ## type ## _ ## fmt ## _nge, fp0, fp1, cc);  break;\
> +    case 14: gen_helper_2i(cmp ## type ## _ ## fmt ## _le, fp0, fp1, cc);   break;\
> +    case 15: gen_helper_2i(cmp ## type ## _ ## fmt ## _ngt, fp0, fp1, cc);  break;\

I wonder if this wouldn't be better structured as a table lookup?


r~