From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer (-VC) Date: Sun, 06 Jun 2010 13:52:07 +0200 Subject: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module In-Reply-To: <20100606114251.66D2114E867@gemini.denx.de> References: <4C0A29C0.7080604@emk-elektronik.de> <4C0A9493.8090008@emk-elektronik.de> <4C0B85D8.4070508@emk-elektronik.de> <20100606114251.66D2114E867@gemini.denx.de> Message-ID: <4C0B8BE7.7090108@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk schrieb: > Dear "Reinhard Meyer (-VC)", > > In message <4C0B85D8.4070508@emk-elektronik.de> you wrote: >> is this patch going to be accepted, or is someone insisting that only >> my port shall return the number of controllers initialized? > > I don't understand what you mean by "only my port". Ben's comment that > board_eth_init() is supposed to retrurn the number of successfully > initialized controllers has been standard policy for a pretty long > time, and many boards do so. > > Eventually the boards you compared against are older ones, and have > not been maintained well, so they misbehave in this regard? > > Best regards, > > Wolfgang Denk > Hello Wolfgang, Is that documented somewhere? I see that the calling function in net.c does NOT care about any positive interger result. Will it care sometime in the future? :) The second problem is that I cannot seem to undo my previous commit in my tree, so any changes I do to my source would come out as a second patch. Would that be accepted? Or do you know what must be done that GIT will issue a new patch with the current and the new changes in one patch? I generate the patches by : git commit -m git format-patch origin what to do to return to , do new edits and generate a new, single patch? Best Regards, Reinhard