From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234Ab0FGHjl (ORCPT ); Mon, 7 Jun 2010 03:39:41 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o577dfle029145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Jun 2010 03:39:41 -0400 Message-ID: <4C0CA2AE.5000908@redhat.com> Date: Mon, 07 Jun 2010 09:41:34 +0200 From: Hans de Goede MIME-Version: 1.0 To: huzaifas@redhat.com CC: linux-media@vger.kernel.org Subject: Re: [PATCH] libv4l1: move VIDIOCCAPTURE to libv4l1 References: <1275637214-22089-1-git-send-email-huzaifas@redhat.com> In-Reply-To: <1275637214-22089-1-git-send-email-huzaifas@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, Looks good, applied Thanks! Regards, Hans On 06/04/2010 09:40 AM, huzaifas@redhat.com wrote: > From: Huzaifa Sidhpurwala > > move VIDIOCCAPTURE to libv4l1 > > Signed-of-by: Huzaifa Sidhpurwala > --- > lib/libv4l1/libv4l1.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/lib/libv4l1/libv4l1.c b/lib/libv4l1/libv4l1.c > index 579f13b..2981c40 100644 > --- a/lib/libv4l1/libv4l1.c > +++ b/lib/libv4l1/libv4l1.c > @@ -967,6 +967,22 @@ int v4l1_ioctl(int fd, unsigned long int request, ...) > > break; > } > + > + case VIDIOCCAPTURE: { > + int *on = arg; > + enum v4l2_buf_type captype = V4L2_BUF_TYPE_VIDEO_CAPTURE; > + > + if (0 == *on) { > + /* dirty hack time. But v4l1 has no STREAMOFF > + * equivalent in the API, and this one at > + * least comes close ... */ > + v4l2_ioctl(fd, VIDIOC_STREAMOFF,&captype); > + } > + > + result = v4l2_ioctl(fd, VIDIOC_OVERLAY, on); > + > + break; > + } > default: > /* Pass through libv4l2 for applications which are using v4l2 through > libv4l1 (this can happen with the v4l1compat.so wrapper preloaded */