All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: armbru@redhat.com, lcapitulino@redhat.com,
	Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation
Date: Mon, 07 Jun 2010 09:48:10 -0500	[thread overview]
Message-ID: <4C0D06AA.4080208@codemonkey.ws> (raw)
In-Reply-To: <AANLkTinsn7VfL1GHYmihjmWc9Vx8mJdxLWwh3P3qZt_o@mail.gmail.com>

On 06/07/2010 09:41 AM, Miguel Di Ciurcio Filho wrote:
> On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>>>> $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0
>>>>
>>>> This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0
>>>> will be a guest device, and they are connected.
>>>>          
>>> Yes.  I'd want separate queries for each, or perhaps a single query that
>>> returns
>>>
>>> { 'hostdev': some-object-with-host-device-properties-only, 'nic':
>>> some-object-that-describes-the-guest-nic }
>>>        
>> We need a query-netdev and then info qdm already provides the guest nic
>> properties.  Just filter out devices that have a netdev property.
>>
>>      
> How about this small draft:
>
> Possible values for "type": tap, user, vde and socket. The 'info'
> object contains all the parameters available via -netdev type,args.
>
> Notice: vlan is still there, unless the support for it is removed, IMHO.
>    

'id' is missing.  Really, s/device/id/ is probably the right thing to do.

vlan's are a totally separate concept.  info netdev shouldn't return 
vlan devices IMHO.  We should have a separate info vlan command that 
shows the vlan topology.

Regards,

Anthony Liguori

> ->  { "execute": "query-netdev" }
> <- {
>        "return": [
>           {
>              "device": "tap.0",
>              "vlan": 0,
>              "type": "tap",
>              "info": {
>                 "script": "/etc/qemu-ifup",
>                 "downscript": "/etc/qemu-ifdown",
>                 "ifname": "tap0",
>              },
>           {
>              "device": "user.0",
>              "type": "user",
>              "info": {
>                 "net": "10.0.2.0",
>                 "netmask": "255.255.255.0"
>              },
>           },
>    

  reply	other threads:[~2010-06-07 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 14:06 [Qemu-devel] [RFC] QMP: Introduce query-netdevices documentation Miguel Di Ciurcio Filho
2010-06-06 15:50 ` [Qemu-devel] " Avi Kivity
2010-06-07 12:57   ` Miguel Di Ciurcio Filho
2010-06-07 13:39     ` Avi Kivity
2010-06-07 13:48       ` Anthony Liguori
2010-06-07 14:41         ` Miguel Di Ciurcio Filho
2010-06-07 14:48           ` Anthony Liguori [this message]
2010-06-07 19:39             ` Miguel Di Ciurcio Filho
2010-06-07 15:01           ` Markus Armbruster
2010-06-07 19:48             ` Miguel Di Ciurcio Filho
2010-06-07 15:54         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0D06AA.4080208@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.