From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OLiqE-0008WM-EF for mharc-grub-devel@gnu.org; Mon, 07 Jun 2010 16:22:38 -0400 Received: from [140.186.70.92] (port=34236 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLiqB-0008UF-De for grub-devel@gnu.org; Mon, 07 Jun 2010 16:22:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLiqA-00013c-6a for grub-devel@gnu.org; Mon, 07 Jun 2010 16:22:35 -0400 Received: from mail-ew0-f214.google.com ([209.85.219.214]:42898) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLiq9-00013B-T8 for grub-devel@gnu.org; Mon, 07 Jun 2010 16:22:34 -0400 Received: by ewy6 with SMTP id 6so2479765ewy.32 for ; Mon, 07 Jun 2010 13:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=UlJbBo8Wj446wUux6Km7SgJw5N989xjTSstc49wJqAQ=; b=E+Vc7NN3sEeLsf4HSgAqfcizyYB4sdbOMHk3ULAD7IOhKznCueds9Zopj53MizyTfd HHI58lAJeVdyo/mexzdu/bbUrynUYiM+tvKSgPkh7iYND233xIMpGpWuMpfsQZzn3I5b f+u6Zyw319jsCRIYRX5L5SoxaohZIjULGuero= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=wi6A5zWiuIskr7DXGintRYwpYX+Pgq4ulr8Cqz9v7i2fCGbd1nHzICkPjPoPGt2hIQ PCn0GQyweSL4QtH/bdMp5o1GZBaUKTuaeAbkMHYX64XR7Cyw5NoR7iNjdvzcIElQ0B0X yePANHURpGRnP6zLYYcuEl0IX+Ej5+YlthNzI= Received: by 10.213.101.8 with SMTP id a8mr1140602ebo.31.1275942151558; Mon, 07 Jun 2010 13:22:31 -0700 (PDT) Received: from debian.bg45.phnet (gprs27.swisscom-mobile.ch [193.247.250.27]) by mx.google.com with ESMTPS id 14sm2902519ewy.2.2010.06.07.13.22.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Jun 2010 13:22:30 -0700 (PDT) Message-ID: <4C0D54FA.3060200@gmail.com> Date: Mon, 07 Jun 2010 22:22:18 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <20100607165842.GL21862@riva.ucam.org> In-Reply-To: <20100607165842.GL21862@riva.ucam.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigA28E330DFB577D807F296E71" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 20:22:36 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA28E330DFB577D807F296E71 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/07/2010 06:58 PM, Colin Watson wrote: > While writing documentation for booting GRUB over the network, I notice= d > that the code to handle (pxe:server_ip:gateway_ip) device names looks > wrong. Shouldn't it be like this? > > =20 Go ahead. > 2010-06-07 Colin Watson > > * fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip. > > =3D=3D=3D modified file 'fs/i386/pc/pxe.c' > --- fs/i386/pc/pxe.c 2010-02-14 12:18:33 +0000 > +++ fs/i386/pc/pxe.c 2010-06-07 16:56:22 +0000 > @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di > return err; > if (*ptr =3D=3D ':') > { > - err =3D parse_ip (ptr + 1, &(data->server_ip), 0); > + err =3D parse_ip (ptr + 1, &(data->gateway_ip), 0); > if (err) > return err; > } > > Thanks, > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigA28E330DFB577D807F296E71 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkwNVQIACgkQNak7dOguQgm8PgD/fqjAAH6Q+wgRBvULo+kiobhA GeCQfEW5Lmd1Zsex9DAA/0IVwy7Jp6QgmRP4Lox2xsjVDCLjnYUhRlhsUtRbcRll =+SXF -----END PGP SIGNATURE----- --------------enigA28E330DFB577D807F296E71--