[PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

[PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

[Colin Watson]

While writing documentation for booting GRUB over the network, I noticed
that the code to handle (pxe:server_ip:gateway_ip) device names looks
wrong.  Shouldn't it be like this?

2010-06-07  Colin Watson  <cjwatson@ubuntu.com>

	* fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.

=== modified file 'fs/i386/pc/pxe.c'
--- fs/i386/pc/pxe.c	2010-02-14 12:18:33 +0000
+++ fs/i386/pc/pxe.c	2010-06-07 16:56:22 +0000
@@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
 	return err;
       if (*ptr == ':')
 	{
-	  err = parse_ip (ptr + 1, &(data->server_ip), 0);
+	  err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
 	  if (err)
 	    return err;
 	}

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

[Colin Watson]

Oh, and speaking of PXE support, what's the point of the pxe_unload
command?  As near as I can tell, it seems to be the equivalent of 'rmmod
pxe'.  Is there some reason one might want to run this if pxe were built
into the core image, or is it cruft that we should remove?

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

[Seth Goldberg]

Quoting Colin Watson, who wrote the following on Mon, 7 Jun 2010:

> Oh, and speaking of PXE support, what's the point of the pxe_unload
> command?  As near as I can tell, it seems to be the equivalent of 'rmmod
> pxe'.  Is there some reason one might want to run this if pxe were built
> into the core image, or is it cruft that we should remove?

  Yea that is a bit weird -- I could understand if pxe_unload called the 
PXE terminate API to free all resources and end the PXE firmware session, but 
the way it is now it seems a bit useless.

  --S

Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On 06/07/2010 06:58 PM, Colin Watson wrote:
> While writing documentation for booting GRUB over the network, I noticed
> that the code to handle (pxe:server_ip:gateway_ip) device names looks
> wrong.  Shouldn't it be like this?
>
>   
Go ahead.
> 2010-06-07  Colin Watson  <cjwatson@ubuntu.com>
>
> 	* fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.
>
> === modified file 'fs/i386/pc/pxe.c'
> --- fs/i386/pc/pxe.c	2010-02-14 12:18:33 +0000
> +++ fs/i386/pc/pxe.c	2010-06-07 16:56:22 +0000
> @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
>  	return err;
>        if (*ptr == ':')
>  	{
> -	  err = parse_ip (ptr + 1, &(data->server_ip), 0);
> +	  err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
>  	  if (err)
>  	    return err;
>  	}
>
> Thanks,
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]