From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OLjLT-0004LV-Co for mharc-grub-devel@gnu.org; Mon, 07 Jun 2010 16:54:55 -0400 Received: from [140.186.70.92] (port=51837 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLjLP-0004Ia-N8 for grub-devel@gnu.org; Mon, 07 Jun 2010 16:54:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLjLK-0007LS-HC for grub-devel@gnu.org; Mon, 07 Jun 2010 16:54:51 -0400 Received: from mail-ew0-f214.google.com ([209.85.219.214]:61918) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLjLK-0007LG-Bi for grub-devel@gnu.org; Mon, 07 Jun 2010 16:54:46 -0400 Received: by ewy6 with SMTP id 6so2493042ewy.32 for ; Mon, 07 Jun 2010 13:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=YMm3EshyI1wQHBf6QDT5r9pcfVkyzPYxK9Mr2/2NB5M=; b=KZE/eJ79ZqG11E5AGA5No9J4400f9vO6FiFSEtPixsAv3QQkwRNIHvu2y2REw51ykE 0OzOMm69jQH2wZB7khwNcuXec62vSEhPcruQzJfS3vvbnofNFOJplCXQX5Eq2kAGssm8 s2OMOD+VxJ7Tm8M7oGGOa7E8ohzQXStUy7diw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=QFMHCUh3V64NYNsuA1pJibLESXYTH6mNW2+NyL5uAutWobdjy60Sr3OER+7iNkUu47 76Py2iyLwhe42Vll1MiaJh9nJGA8TpQ4/kHbJ0eHpvVD5pHsOEfyEwZ4zQ660ofZHN8Z ayrZ8va7lgJEUuJU8woBkxlu1d37EFMyaaH/8= Received: by 10.213.20.142 with SMTP id f14mr1228199ebb.46.1275944085229; Mon, 07 Jun 2010 13:54:45 -0700 (PDT) Received: from debian.bg45.phnet (gprs27.swisscom-mobile.ch [193.247.250.27]) by mx.google.com with ESMTPS id 15sm2883017ewy.12.2010.06.07.13.54.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Jun 2010 13:54:43 -0700 (PDT) Message-ID: <4C0D5C91.1010303@gmail.com> Date: Mon, 07 Jun 2010 22:54:41 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <20100603125556.GT21862@riva.ucam.org> In-Reply-To: <20100603125556.GT21862@riva.ucam.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig1A5F3CB8BAECC4936D04B01A" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Complete 'set root=(' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 20:54:53 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1A5F3CB8BAECC4936D04B01A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead. On 06/03/2010 02:55 PM, Colin Watson wrote: > While reviewing the Texinfo documentation for references to GRUB Legacy= > constructs that needed to be updated, I found some discussion of > completion that used "root (" as an example. For GRUB 2, this > would need to become "set root=3D(" - but that doesn't work! The > completion code isn't smart enough to complete only the part after the > '=3D' in this case. > > What do people think about the following patch, which makes this work s= o > that we can document it with a clear conscience? > > 2010-06-03 Colin Watson > > * normal/completion.c (grub_normal_do_completion): When > completing arguments to "set" and the current word contains an > equals sign, skip to after the equals sign before starting > completion. > > =3D=3D=3D modified file 'normal/completion.c' > --- normal/completion.c 2010-01-20 08:12:47 +0000 > +++ normal/completion.c 2010-06-03 12:49:47 +0000 > @@ -414,6 +414,14 @@ grub_normal_do_completion (char *buf, in > else > current_word =3D argv[argc - 1]; > =20 > + if (argc > 1 && ! grub_strcmp (argv[0], "set")) > + { > + char *equals =3D grub_strchr (current_word, '=3D'); > + if (equals) > + /* Complete the value of the variable. */ > + current_word =3D equals + 1; > + } > + > /* Determine the state the command line is in, depending on the > state, it can be determined how to complete. */ > cmdline_state =3D get_state (buf); > > Thanks, > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig1A5F3CB8BAECC4936D04B01A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkwNXJEACgkQNak7dOguQgnJqQD/ebQLZAppiBchfJfgaEHRcnIY q4ZDIID8jwqfPTAn3VcA/jfX7xbJ24S4fzJpkHU0UNHUbRb0cqoBLIAKpFXS5VXX =03ib -----END PGP SIGNATURE----- --------------enig1A5F3CB8BAECC4936D04B01A--