From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OLjh4-0007kD-2i for mharc-grub-devel@gnu.org; Mon, 07 Jun 2010 17:17:14 -0400 Received: from [140.186.70.92] (port=36974 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLjgw-0007iQ-47 for grub-devel@gnu.org; Mon, 07 Jun 2010 17:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLjgu-0002DM-Bm for grub-devel@gnu.org; Mon, 07 Jun 2010 17:17:06 -0400 Received: from ey-out-1920.google.com ([74.125.78.148]:53306) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLjgu-0002DD-1k for grub-devel@gnu.org; Mon, 07 Jun 2010 17:17:04 -0400 Received: by ey-out-1920.google.com with SMTP id 13so706053eye.34 for ; Mon, 07 Jun 2010 14:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=cxF8UaZyyLbL+Z9QN5NWcwWe59QrJ3u8Ms7O/RlXUfI=; b=tnS2+KwTIq4FGgHdBDCDECrrjYM2Si8ilOJ2ZIXzxSJMYSdmiyvxg7y2dkxmSLktLW HoUmDpgZZmJX9VdwGVDYmcWEAITRxP6vaN6bnpUQBqFXYjK1/EiovNY2rE69u5dhz3Bu 5lQa13OyER+6L9zBdJiwH2ZBoPk8LmvQPlE2Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=aBJNJDqv1s3h/fcPwTGI9/KtXTrgnKzqTOFliAXfmFwRpsa3IKdSQ9I9Tf/6tmssue 3KybOah9oq8eJn+HZ3biO2uCXjPO4gw9fAItDsGLdvxl46VH3aSbT/GgYtKl+xBX0xjQ jEvjkOEnWtyxS1IOwqgoKNu4As6LKVqS8aoJc= Received: by 10.213.5.5 with SMTP id 5mr1247096ebt.18.1275945422917; Mon, 07 Jun 2010 14:17:02 -0700 (PDT) Received: from debian.bg45.phnet (gprs27.swisscom-mobile.ch [193.247.250.27]) by mx.google.com with ESMTPS id 16sm2890778ewy.7.2010.06.07.14.17.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Jun 2010 14:17:00 -0700 (PDT) Message-ID: <4C0D61C3.6070705@gmail.com> Date: Mon, 07 Jun 2010 23:16:51 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <4C083DF0.6080508@gmail.com> In-Reply-To: <4C083DF0.6080508@gmail.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig19674BA08182318B1308CD68" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] File name transformations (split into 7 diffs) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 21:17:12 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig19674BA08182318B1308CD68 Content-Type: multipart/alternative; boundary="------------080301040403020109060503" This is a multi-part message in MIME format. --------------080301040403020109060503 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Regarding file-name-transformations_1.diff: phcoder@debian.bg45.phnet:~$ /usr/local/bin/grub-mkfont --help Usage: /usr/local/bin/grub-mkfont [OPTIONS] FONT_FILES So I would prefer not to use basename for uniformity. Otherwise patch 1 is ok. On 06/04/2010 01:42 AM, Gr=C3=A9goire Sutre wrote: > Hi, > > This is the same patch as I sent before, but this time split into 7 > diffs (which must be successively applied in order) and with a cleaner > changelog. I hope that this will facilitate the review. > > This version does not include the --root-directory addition to > grub-mkconfig, as this is quite orthognal to the goal of the patch (fil= e > name transformation). > > I welcome your comments, > > Gr=C3=A9goire > > --- mostly taken from my previous message -----------------------------= - > > The attached patch fixes problems with file name transformations, which= > are partly broken in trunk. With this patch, several installations of > grub can coexist with no conflict (at least they should), sharing > however the same configuration directory (etc/grub.d). > > For instance: > > ./configure --program-transform-name=3Ds,grub,aaa, > > will install bin/aaa-*, sbin/aaa-*, etc. The default grub directory wil= l > be /boot/aaa, modules will be installed there and grub-mkconfig will > look for them there. > > The main changes in the patch are: > > - configure defines three new variables, accounting for transformations= : > . pkgdatadir (${datadir}/grub) > . pkglibrootdir (${libdir}/grub) > . defaultbootdir (/boot/grub, or /grub if OS is NetBSD or OpenBSD) > > - these variables are used in Makefile and in util/... scripts > > - output of --help and of --version in scripts uses `basename $0` and > the same format as the one in binaries. > > - in Makefile, the help2man, .info, and .mo rules also account for > file name transformations. > > - grub-mkconfig exports GRUB_DIR, which is used by grub-mkconfig_lib > and by 00_header. > > -----------------------------------------------------------------------= > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------080301040403020109060503 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Regarding file-name-transformations_1.diff:
phcoder@debian.bg45.phnet:~$ /usr/local/bin/grub-mkfont --h= elp
Usage: /usr/local/bin/grub-mkfont [OPTIONS] FONT_FILES

So I would prefer not to use basename for uniformity. Otherwise patch 1 is ok.

On 06/04/2010 01:42 AM, Gr=C3=A9goire Sutre wrote:
Hi,

This is the same patch as I sent before, but this time split into 7
diffs (which must be successively applied in order) and with a cleaner
changelog.=C2=A0 I hope that this will facilitate the review.

This version does not include the --root-directory addition to
grub-mkconfig, as this is quite orthognal to the goal of the patch (file
name transformation).

I welcome your comments,

Gr=C3=A9goire

--- mostly taken from my previous message ------------------------------

The attached patch fixes problems with file name transformations, which
are partly broken in trunk.=C2=A0 With this patch, several installations = of
grub can coexist with no conflict (at least they should), sharing
however the same configuration directory (etc/grub.d).

For instance:

=2E/configure --program-transform-name=3Ds,grub,aaa,

will install bin/aaa-*, sbin/aaa-*, etc. The default grub directory will
be /boot/aaa, modules will be installed there and grub-mkconfig will
look for them there.

The main changes in the patch are:

- configure defines three new variables, accounting for transformations:
=C2=A0 . pkgdatadir=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (${datadir}/grub)=
=C2=A0 . pkglibrootdir=C2=A0=C2=A0=C2=A0 (${libdir}/grub)
=C2=A0 . defaultbootdir=C2=A0=C2=A0 (/boot/grub, or /grub if OS is NetBSD= or OpenBSD)

- these variables are used in Makefile and in util/... scripts

- output of --help and of --version in scripts uses `basename $0` and
=C2=A0 the same format as the one in binaries.

- in Makefile, the help2man, .info, and .mo rules also account for
=C2=A0 file name transformations.

- grub-mkconfig exports GRUB_DIR, which is used by grub-mkconfig_lib
=C2=A0 and by 00_header.

----------------------------------------------------------------------- 


_______________________________________________
Grub-devel mailing list
=
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
  


--=20
Regards
Vladimir '=CF=86-coder/phcoder' Serbinenko
--------------080301040403020109060503-- --------------enig19674BA08182318B1308CD68 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkwNYcMACgkQNak7dOguQgk3ugD/ZeMZ1/le6FICsylQOw/02Hbr CloH+AriPIDZ4+DFTL0A/1yYo4i+wUavJi26hynA2hLtZNBFeFZuC86T/jXYZsgf =tJCH -----END PGP SIGNATURE----- --------------enig19674BA08182318B1308CD68--