From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] KVM: MMU: Atomically check for accessed bit when dropping an spte
Date: Tue, 08 Jun 2010 08:51:47 +0300 [thread overview]
Message-ID: <4C0DDA73.2060106@redhat.com> (raw)
In-Reply-To: <4C0DA5EA.80009@cn.fujitsu.com>
On 06/08/2010 05:07 AM, Xiao Guangrong wrote:
>
> Avi Kivity wrote:
>
>
>> +static u64 __xchg_spte(u64 *sptep, u64 new_spte)
>> +{
>> +#ifdef CONFIG_X86_64
>> + return xchg(sptep, new_spte);
>> +#else
>> + u64 old_spte;
>> +
>> + do {
>> + old_spte = *sptep;
>> + } while (cmpxchg64(sptep, old_spte, new_spte) != old_spte);
>> +
>> + return old;
>>
> it's a typo: 'old' -> 'old_spte' :-)
>
Thanks. Reminds me I need to test i386 too.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-06-08 5:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 7:10 [PATCH v2 0/4] Fix accessed bit tracking Avi Kivity
2010-06-07 7:10 ` [PATCH v2 1/4] KVM: MMU: Introduce drop_spte() Avi Kivity
2010-06-07 7:10 ` [PATCH v2 2/4] KVM: MMU: Move accessed/dirty bit checks from rmap_remove() to drop_spte() Avi Kivity
2010-06-07 8:16 ` Lai Jiangshan
2010-06-07 9:01 ` Avi Kivity
2010-06-07 7:10 ` [PATCH v2 3/4] KVM: MMU: Atomically check for accessed bit when dropping an spte Avi Kivity
2010-06-08 2:07 ` Xiao Guangrong
2010-06-08 5:51 ` Avi Kivity [this message]
2010-06-07 7:10 ` [PATCH v2 4/4] KVM: MMU: Don't drop accessed bit while updating " Avi Kivity
2010-06-07 8:43 ` [PATCH v2 0/4] Fix accessed bit tracking Lai Jiangshan
2010-06-07 9:00 ` Avi Kivity
2010-06-08 2:35 ` Xiao Guangrong
2010-06-08 5:24 ` Avi Kivity
2010-06-08 6:53 ` Xiao Guangrong
2010-06-08 7:54 ` Avi Kivity
2010-06-08 8:30 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0DDA73.2060106@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.