From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Tue, 08 Jun 2010 09:34:28 -0500 Subject: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init() In-Reply-To: <201006080004.05839.vapier@gentoo.org> References: <1275935487-2031-1-git-send-email-timur@freescale.com> <201006071849.29511.vapier@gentoo.org> <4C0D78D6.2010707@freescale.com> <201006080004.05839.vapier@gentoo.org> Message-ID: <4C0E54F4.8000006@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > the documentation currently states that a negative value is permissible and > thus "int" is correct. as for the code that actually reads the result, that > is by & large common code, so logic along those lines isnt terribly important. The conclusion I drew from Andy's comments is that functions which initialize more than one device should not return a negative value. That makes sense to me. Perhaps the documentation should be updated to incorporate this idea?