All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 3/2] dm: table load must always try dm_setup_md_queue
Date: Wed, 09 Jun 2010 14:38:56 +0900	[thread overview]
Message-ID: <4C0F28F0.5090604@ct.jp.nec.com> (raw)
In-Reply-To: <20100604201524.GC4917@redhat.com>

Hi Mike,

On 06/05/2010 05:15 AM +0900, Mike Snitzer wrote:
> @@ -2164,7 +2164,8 @@ static int dm_init_request_based_queue(s
>  {
>  	struct request_queue *q = NULL;
>  
> -	BUG_ON(md->queue->elevator);
> +	if (unlikely(md->queue->elevator))
> +		return 1;

I think the "unlikely" should be rather "likely", since
dm_init_request_based_queue() is now called whenever request-based
table is loaded even after the actual initialization has been done.

For others,
Acked-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>

Thanks,
Kiyoshi Ueda

  reply	other threads:[~2010-06-09  5:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 12:47 [PATCH v4 0/2] dm: restrict conflicting table loads and improve queue initialization Mike Snitzer
2010-05-27 12:47 ` [PATCH v4 1/2] dm: prevent table type changes after initial table load Mike Snitzer
2010-06-29 11:40   ` Alasdair G Kergon
2010-06-29 13:52     ` Mike Snitzer
2010-06-29 14:19       ` Alasdair G Kergon
2010-06-29 15:07         ` Mike Snitzer
2010-05-27 12:47 ` [PATCH v4 2/2 "v11"] dm: only initialize full request_queue for request-based device Mike Snitzer
2010-06-04 20:15   ` [PATCH 3/2] dm: table load must always try dm_setup_md_queue Mike Snitzer
2010-06-09  5:38     ` Kiyoshi Ueda [this message]
2010-06-09  8:53       ` Mike Snitzer
2010-06-10  2:54         ` Kiyoshi Ueda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0F28F0.5090604@ct.jp.nec.com \
    --to=k-ueda@ct.jp.nec.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.