From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55380 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMGT0-0002hR-GL
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 04:16:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OMGQa-0001GN-OF
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 04:14:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62064)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OMGQa-0001GF-Ct
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 04:14:24 -0400
Message-ID: <4C0F4D5B.9070806@redhat.com>
Date: Wed, 09 Jun 2010 10:14:19 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code
References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com>	<m3bpbr8az0.fsf@blackfin.pond.sub.org>
	<4C08B80F.4040401@redhat.com>	<m3mxvb2etn.fsf@blackfin.pond.sub.org>
	<4C08EA1B.3040002@redhat.com>
	<m3y6eo65vi.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3y6eo65vi.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 06/09/10 09:07, Markus Armbruster wrote:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>> On 06/04/10 13:54, Markus Armbruster wrote:
>> If there is strong feeling we should do it this way instead, I can
>> change the code to do it this way instead. I am not married to the
>> current approach, I just find it the lesser evil.
> 
> I'm making suggestions, not demands.  If you still prefer your way after
> considering my suggestions, go with it.
> 
> For what it's worth, pushing OS-dependent bits out of the option parsing
> allows for:
> 
>     qemu: --frobnicate: Can't frobnicate under Windows
> 
> instead of
> 
>     qemu: --frobnicate: invalid option

That is true, on the other hand I think it would be cleaner to not
advertise options on an OS where it is not supported. Ideally I would
like them to not show up in qemu --help at all.

Cheers,
Jes