From: Avi Kivity <avi@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options
Date: Wed, 09 Jun 2010 15:03:18 +0300 [thread overview]
Message-ID: <4C0F8306.70509@redhat.com> (raw)
In-Reply-To: <1276033807-22718-1-git-send-email-mgoldish@redhat.com>
On 06/09/2010 12:50 AM, Michael Goldish wrote:
> Signed-off-by: Michael Goldish<mgoldish@redhat.com>
> ---
> client/tests/kvm/kvm_vm.py | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index 94bacdf..f3c05f3 100755
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -268,6 +268,12 @@ class VM:
> def add_pcidevice(help, host):
> return " -pcidevice host=%s" % host
>
> + def add_kernel(help, filename):
> + return " -kernel %s" % filename
> +
> + def add_kernel_cmdline(help, cmdline):
> + return " -append %s" % cmdline
> +
>
Shell quoting is a good idea here. Everywhere else too, in fact, but
-append is very likely to contain spaces.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-09 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 21:50 [KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options Michael Goldish
2010-06-08 21:50 ` [KVM-AUTOTEST PATCH v2 2/4] KVM test: add boolean 'testdev' VM parameter for RHEL-6 style unit tests Michael Goldish
2010-06-08 21:50 ` [KVM-AUTOTEST PATCH v2 3/4] KVM test: add wrapper for RHEL-6 style unittests Michael Goldish
2010-06-08 21:50 ` [KVM-AUTOTEST PATCH v2 4/4] KVM test: add sample RHEL-6 style unittest config file Michael Goldish
2010-06-09 12:03 ` Avi Kivity [this message]
2010-06-09 15:25 ` [KVM-AUTOTEST PATCH v2 1/4] KVM test: support -kernel and -append command line options Michael Goldish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0F8306.70509@redhat.com \
--to=avi@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mgoldish@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.