From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 7/58] new helper: end_writeback() Date: Wed, 09 Jun 2010 16:50:30 +0300 Message-ID: <4C0F9C26.60509@panasas.com> References: <20100609130216.GB3861@infradead.org> <20100609132018.GZ31073@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Al Viro , linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from daytona.panasas.com ([67.152.220.89]:15229 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752679Ab0FINuc (ORCPT ); Wed, 9 Jun 2010 09:50:32 -0400 In-Reply-To: <20100609132018.GZ31073@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06/09/2010 04:20 PM, Al Viro wrote: > On Wed, Jun 09, 2010 at 09:02:16AM -0400, Christoph Hellwig wrote: >> On Tue, Jun 08, 2010 at 11:16:02PM +0100, Al Viro wrote: >>> >>> Essentially, the minimal variant of ->evict_inode(). It's >>> a trimmed-down clear_inode(), sans any fs callbacks. Once >>> it returns we know that no async writeback will be happening; >>> every ->evict_inode() instance should do that once and do that >>> before doing anything ->write_inode() could interfere with >>> (e.g. freeing the on-disk inode). >> >> Naming seems a bit unfortunate - this really sounds like something >> in page writeback. In fact I'd almost bet we had a function with >> that name there in the past. >> >> Care to slap an inode_ prefix on it? > > Ehh... I'd been tempted to call it end_async or something like that. > I'm not particulary fond of the name; any better suggestions are welcome. > > The point of what's being done in that function is that it acts as a barrier; > "wait for async activity to run down; new one won't be started since it's > already marked I_FREEING". It was odd for me to. I had to go look at code to understand what it's for. I would prefer the word "wait" in the name or barrier. eg. wait_writeback. end_writeback sounds like something you should call from ->write_end Just my $0.017 Boaz