From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH ver4] exofs: New truncate sequence
Date: Wed, 09 Jun 2010 18:26:22 +0300
Message-ID: <4C0FB29E.1070208@panasas.com>
References: <E1OM7Bz-0004ez-EC@ZenIV.linux.org.uk> <4C0F5960.6090305@panasas.com> <20100609100213.GC15403@lst.de> <4C0F7653.9080207@panasas.com> <4C0F7695.2020800@panasas.com> <20100609135512.GA26691@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Al Viro <viro@ftp.linux.org.uk>, linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from daytona.panasas.com ([67.152.220.89]:62568 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1756931Ab0FIP0Y (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 9 Jun 2010 11:26:24 -0400
In-Reply-To: <20100609135512.GA26691@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 06/09/2010 04:55 PM, Christoph Hellwig wrote:
>> +	if (unlikely(ret)) {
>> +		struct inode *inode = mapping->host;
>> +		loff_t to = pos + len;
>>  
>> +		if (to > inode->i_size)
>> +			truncate_pagecache(inode, to, inode->i_size);
>> +	}
> 
> Might be worth to add a exofs_write_failed helper similar to ext2 that
> can be shared with write_end, and once added ->direct_IO?
> 
>> +		error = inode_newsize_ok(inode, iattr->ia_size);
>> +		if (unlikely(error))
>> +			return error;
> 
> This has been folded into inode_change_ok in vfs.git #for_next, you
> can drop it.
> 

Christoph didn't you have a patch to simple_write_end, is it in vfs/for-next
This patch adds this comment:

+	/* TODO: once simple_write_end marks inode dirty remove */
 	if (i_size != inode->i_size)
 		mark_inode_dirty(inode);

Please CC me on that patch

Thanks for the review
Boaz