[PATCH]security:policydb.h Fix a space with "SE Linux"

[PATCH]security:policydb.h Fix a space with "SE Linux"

[Justin P. Mattock]

Fix the space between "SE Linux", to match the other
definitions of "SELinux", in the system.
 
 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 security/selinux/ss/policydb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/security/selinux/ss/policydb.h b/security/selinux/ss/policydb.h
index 26d9adf..7da08b2 100644
--- a/security/selinux/ss/policydb.h
+++ b/security/selinux/ss/policydb.h
@@ -281,7 +281,7 @@ extern int policydb_read(struct policydb *p, void *fp);
 #define OBJECT_R_VAL 1
 
 #define POLICYDB_MAGIC SELINUX_MAGIC
-#define POLICYDB_STRING "SE Linux"
+#define POLICYDB_STRING "SELinux"
 
 struct policy_file {
 	char *data;
-- 
1.7.1.rc1.21.gf3bd6


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH]security:policydb.h Fix a space with "SE Linux"

[James Morris]

On Wed, 9 Jun 2010, Justin P. Mattock wrote:

> Fix the space between "SE Linux", to match the other
> definitions of "SELinux", in the system.
>  
>  Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

NAK, please look at how this is used.


> 
> ---
>  security/selinux/ss/policydb.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/selinux/ss/policydb.h b/security/selinux/ss/policydb.h
> index 26d9adf..7da08b2 100644
> --- a/security/selinux/ss/policydb.h
> +++ b/security/selinux/ss/policydb.h
> @@ -281,7 +281,7 @@ extern int policydb_read(struct policydb *p, void *fp);
>  #define OBJECT_R_VAL 1
>  
>  #define POLICYDB_MAGIC SELINUX_MAGIC
> -#define POLICYDB_STRING "SE Linux"
> +#define POLICYDB_STRING "SELinux"
>  
>  struct policy_file {
>  	char *data;
> -- 
> 1.7.1.rc1.21.gf3bd6
> 
> 
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
> 

-- 
James Morris
<jmorris@namei.org>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH]security:policydb.h Fix a space with "SE Linux"

[Justin P. Mattock]

On 06/09/2010 04:42 PM, James Morris wrote:
> On Wed, 9 Jun 2010, Justin P. Mattock wrote:
>
>> Fix the space between "SE Linux", to match the other
>> definitions of "SELinux", in the system.
>>
>>   Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>
> NAK, please look at how this is used.
>

ahh.. I thought this was printk ing things
into dmesg.. but it's not it's a strlen.

>
>>
>> ---
>>   security/selinux/ss/policydb.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/security/selinux/ss/policydb.h b/security/selinux/ss/policydb.h
>> index 26d9adf..7da08b2 100644
>> --- a/security/selinux/ss/policydb.h
>> +++ b/security/selinux/ss/policydb.h
>> @@ -281,7 +281,7 @@ extern int policydb_read(struct policydb *p, void *fp);
>>   #define OBJECT_R_VAL 1
>>
>>   #define POLICYDB_MAGIC SELINUX_MAGIC
>> -#define POLICYDB_STRING "SE Linux"
>> +#define POLICYDB_STRING "SELinux"
>>
>>   struct policy_file {
>>   	char *data;
>> --
>> 1.7.1.rc1.21.gf3bd6
>>
>>
>> --
>> This message was distributed to subscribers of the selinux mailing list.
>> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
>> the words "unsubscribe selinux" without quotes as the message.
>>
>


o.k. throwing in the reject pile..
thanks for looking..

Justin P. Mattock

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH]security:policydb.h Fix a space with "SE Linux"

[Stephen Smalley]

On Wed, 2010-06-09 at 16:54 -0700, Justin P. Mattock wrote:
> On 06/09/2010 04:42 PM, James Morris wrote:
> > On Wed, 9 Jun 2010, Justin P. Mattock wrote:
> >
> >> Fix the space between "SE Linux", to match the other
> >> definitions of "SELinux", in the system.
> >>
> >>   Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> >
> > NAK, please look at how this is used.
> >
> 
> ahh.. I thought this was printk ing things
> into dmesg.. but it's not it's a strlen.

That string is part of the header of the binary policy file.  You can't
change it without breaking compatibility.  It has always been that way
in mainline Linux 2.6, and predates that in the SELinux code (circa
2002).

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH]security:policydb.h Fix a space with "SE Linux"

[Justin P. Mattock]

On 06/10/2010 05:37 AM, Stephen Smalley wrote:
> On Wed, 2010-06-09 at 16:54 -0700, Justin P. Mattock wrote:
>> On 06/09/2010 04:42 PM, James Morris wrote:
>>> On Wed, 9 Jun 2010, Justin P. Mattock wrote:
>>>
>>>> Fix the space between "SE Linux", to match the other
>>>> definitions of "SELinux", in the system.
>>>>
>>>>    Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> NAK, please look at how this is used.
>>>
>>
>> ahh.. I thought this was printk ing things
>> into dmesg.. but it's not it's a strlen.
>
> That string is part of the header of the binary policy file.  You can't
> change it without breaking compatibility.  It has always been that way
> in mainline Linux 2.6, and predates that in the SELinux code (circa
> 2002).
>

I did see, where it's being called
but while looking at the code, I didn't
get what it was doing(to the most part)

then after really looking at strlen
it's(like what you had said)
the header of the binary file or
the string length

so to change this would breaks
lots of things!!("great just
what I need"..)

thanks for looking at this.

Justin P. Mattock


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.