All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
	git@vger.kernel.org, johan@herland.net, davvid@gmail.com,
	Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH next 2/2] Remove python 2.5'isms
Date: Thu, 10 Jun 2010 09:31:11 +0200	[thread overview]
Message-ID: <4C1094BF.5070907@drmicha.warpmail.net> (raw)
In-Reply-To: <AANLkTikmdsJwy06WuRwpLEKzZE45VZcvPDDxnW1OCb8K@mail.gmail.com>

Sverre Rabbelier venit, vidit, dixit 09.06.2010 23:28:
> Heya,
> 
> On Wed, Jun 9, 2010 at 23:24, Brandon Casey <casey@nrlssc.navy.mil> wrote:
>> The following python 2.5 features were worked around:
> 
> Thanks for fixing this, although it makes me sad to see the code
> uglify the way it has :P. I guess that's the pain of backwards
> compatibility.
> 

I doesn't need to be ugly. Why not put the Popen thing in a def
somewhere? Is there any remaining uglyness besides this:

-    return any(url.startswith(i) for i in prefixes)
+    for prefix in prefixes:
+        if url.startswith(prefix):
+            return True
+    return False

Pythonish version:
-    return any(url.startswith(i) for i in prefixes)
+    return True in (url.startswith(i) for i in prefixes)

Note that due to the use of an iterator (which P2.4 has) rather than a
list or set, the expression is just as efficient, i.e. calls
startswith() only as often as necessary.

Michael

  parent reply	other threads:[~2010-06-10  7:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09 21:23 [PATCH next 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-09 21:24 ` [PATCH next 2/2] Remove python 2.5'isms Brandon Casey
2010-06-09 21:28   ` Sverre Rabbelier
2010-06-09 22:40     ` Johan Herland
2010-06-09 22:46       ` Sverre Rabbelier
2010-06-10  0:24       ` [PATCH next 2/2 v2] " Brandon Casey
2010-06-10  7:13         ` Sverre Rabbelier
2010-06-10  9:28         ` Michael J Gruber
2010-06-10 15:41           ` David Ripton
2010-06-11 13:28             ` Michael J Gruber
2010-06-10  7:31     ` Michael J Gruber [this message]
2010-06-10  7:35       ` [PATCH next 2/2] " Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1094BF.5070907@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=casey@nrlssc.navy.mil \
    --cc=davvid@gmail.com \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.