All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: KVM General <kvm@vger.kernel.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Asias He <asias.hejun@gmail.com>
Subject: Re: KVM_EXIT_HALT and KVM_CREATE_IRQCHIP
Date: Thu, 10 Jun 2010 13:03:04 +0300	[thread overview]
Message-ID: <4C10B858.1020500@redhat.com> (raw)
In-Reply-To: <4C10B5D8.2040409@cs.helsinki.fi>

On 06/10/2010 12:52 PM, Pekka Enberg wrote:

>
> How is the guest supposed to halt the hypervisor if KVM_CREATE_IRQCHIP 
> is being used? The kvm_emulate_halt() function seems to handle the 
> halt event completely if irqchip_in_kernel() returns true and thus 
> never exits to the hypervisor.

"The hypervisor" is the combination of userspace and kvm.  Without 
KVM_CREATE_IRQCHIP, HLT is emulated in userspace.  With 
KVM_CREATE_IRQCHIP, HLT is emulated in the kernel.  Emulating HLT in the 
kernel results in a faster return from HLT, which occurs frequently.

If you need to break out of the kernel, send a signal to the thread 
that's running the vcpu.  That works whether the guest is running or 
sleeping.

> I see there's a KVM_GET_MP_STATE ioctl that can be used to check if 
> state is KVM_MP_STATE_HALTED but as we never exit to the hypervisor, 
> how is this supposed to work? Am I missing something obvious here?

In general you only rarely want to check the state (example are for 
debugging and for live migration).  It's not a stable value (the guest 
executing HLT, or a guest interrupt delivered, will change its value).  
What's your use case?

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-06-10 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-10  9:52 KVM_EXIT_HALT and KVM_CREATE_IRQCHIP Pekka Enberg
2010-06-10 10:03 ` Avi Kivity [this message]
2010-06-10 10:15   ` Pekka Enberg
2010-06-10 10:54     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C10B858.1020500@redhat.com \
    --to=avi@redhat.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.