From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38507 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMemY-0001S9-FU
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 06:14:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OMemX-0006vL-5g
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 06:14:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17241)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OMemW-0006v5-VM
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 06:14:41 -0400
Message-ID: <4C10BB0C.8080300@redhat.com>
Date: Thu, 10 Jun 2010 12:14:36 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTikMjEneitQJy0ABsx_sSYxCC3R2K95hXZ-J37zs@mail.gmail.com>
	<4C0BDD61.9020908@redhat.com>
	<AANLkTinukX8kAE4fqFEJt6I5AN1qEynuzpslyLah0SjH@mail.gmail.com>
In-Reply-To: <AANLkTinukX8kAE4fqFEJt6I5AN1qEynuzpslyLah0SjH@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 06/09/2010 09:59 PM, Blue Swirl wrote:
>>>   struct APICState {
>>> -    CPUState *cpu_env;
>>> +    void *cpu_env;
>>
>> I proposed having an opaque CPUState type in hw/ but it was rejected. But I
>> don't think using a void pointer is any better.
>
> It's not necessary for the patch. Maybe it's possible to avoid all
> CPUState references in apic.c by pushing the dependencies to pc.c. It
> could affect performance though.

I think it's unnecessary.  But I'd leave CPUState

Paolo