From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: James Morris <jmorris@namei.org>, selinux@tycho.nsa.gov
Subject: Re: [PATCH]security:policydb.h Fix a space with "SE Linux"
Date: Thu, 10 Jun 2010 06:47:33 -0700 [thread overview]
Message-ID: <4C10ECF5.7050206@gmail.com> (raw)
In-Reply-To: <1276173423.25808.27.camel@moss-pluto.epoch.ncsc.mil>
On 06/10/2010 05:37 AM, Stephen Smalley wrote:
> On Wed, 2010-06-09 at 16:54 -0700, Justin P. Mattock wrote:
>> On 06/09/2010 04:42 PM, James Morris wrote:
>>> On Wed, 9 Jun 2010, Justin P. Mattock wrote:
>>>
>>>> Fix the space between "SE Linux", to match the other
>>>> definitions of "SELinux", in the system.
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>> NAK, please look at how this is used.
>>>
>>
>> ahh.. I thought this was printk ing things
>> into dmesg.. but it's not it's a strlen.
>
> That string is part of the header of the binary policy file. You can't
> change it without breaking compatibility. It has always been that way
> in mainline Linux 2.6, and predates that in the SELinux code (circa
> 2002).
>
I did see, where it's being called
but while looking at the code, I didn't
get what it was doing(to the most part)
then after really looking at strlen
it's(like what you had said)
the header of the binary file or
the string length
so to change this would breaks
lots of things!!("great just
what I need"..)
thanks for looking at this.
Justin P. Mattock
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2010-06-10 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 22:12 [PATCH]security:policydb.h Fix a space with "SE Linux" Justin P. Mattock
2010-06-09 23:42 ` James Morris
2010-06-09 23:54 ` Justin P. Mattock
2010-06-10 12:37 ` Stephen Smalley
2010-06-10 13:47 ` Justin P. Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C10ECF5.7050206@gmail.com \
--to=justinmattock@gmail.com \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.