From: Nigel Cunningham <ncunningham@crca.org.au>
To: Jiri Slaby <jslaby@suse.cz>
Cc: rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [linux-pm] [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle
Date: Fri, 11 Jun 2010 19:46:04 +1000 [thread overview]
Message-ID: <4C1205DC.1080200@crca.org.au> (raw)
In-Reply-To: <1275468768-28229-1-git-send-email-jslaby@suse.cz>
Hi.
(Sorry Jiri - unintentionally originally replied only to you).
On 02/06/10 18:52, Jiri Slaby wrote:
> Hi,
>
> I addressed the comments I got on the previous RFC. I left the handles
> in place, the functions in hibernate_io_ops now works on them. Further
> I got rid of the memory barriers and minimized global variables as much
> as possible. Comments welcome.
I would like to hear the arguments for using these handles. I understand
there may have been some previous discussion, but am unable to find it.
It seems far more sensible to me to not pass around a handle that
virtually nothing actually uses, and instead store and utilise the state
in the place where it is actually useful. If we had more than one struct
hibernate_io_handle in use at a time, I could understand going this way.
As it stands, however...
Regards,
Nigel
next prev parent reply other threads:[~2010-06-11 9:46 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 8:52 [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle Jiri Slaby
2010-06-02 8:52 ` [PATCH 2/9] PM / Hibernate: add hibernate_io_ops Jiri Slaby
2010-06-24 15:23 ` Rafael J. Wysocki
2010-06-24 15:23 ` Rafael J. Wysocki
2010-06-02 8:52 ` Jiri Slaby
2010-06-02 8:52 ` [PATCH 3/9] PM / Hibernate: user, implement user_ops writer Jiri Slaby
2010-06-02 8:52 ` Jiri Slaby
2010-06-24 16:27 ` Rafael J. Wysocki
2010-06-24 16:27 ` Rafael J. Wysocki
2010-06-02 8:52 ` [PATCH 4/9] PM / Hibernate: user, implement user_ops reader Jiri Slaby
2010-06-25 13:37 ` Rafael J. Wysocki
2010-06-25 13:37 ` Rafael J. Wysocki
2010-06-02 8:52 ` Jiri Slaby
2010-06-02 8:52 ` [PATCH 5/9] PM / Hibernate: add chunk i/o support Jiri Slaby
2010-06-02 8:52 ` Jiri Slaby
2010-06-25 13:44 ` Rafael J. Wysocki
2010-06-25 13:44 ` Rafael J. Wysocki
2010-06-02 8:52 ` [PATCH 6/9] PM / Hibernate: split snapshot_read_next Jiri Slaby
2010-06-02 8:52 ` Jiri Slaby
2010-06-25 13:53 ` Rafael J. Wysocki
2010-06-25 13:53 ` Rafael J. Wysocki
2010-07-19 16:42 ` Jiri Slaby
2010-07-19 16:42 ` Jiri Slaby
2010-06-02 8:52 ` [PATCH 7/9] PM / Hibernate: split snapshot_write_next Jiri Slaby
2010-06-25 13:54 ` Rafael J. Wysocki
2010-06-25 13:54 ` Rafael J. Wysocki
2010-06-02 8:52 ` Jiri Slaby
2010-06-02 8:52 ` [PATCH 8/9] PM / Hibernate: dealign swsusp_info Jiri Slaby
2010-06-02 8:52 ` Jiri Slaby
2010-06-25 13:54 ` Rafael J. Wysocki
2010-06-25 13:54 ` Rafael J. Wysocki
2010-06-02 8:52 ` [PATCH 9/9] PM / Hibernate: move non-swap code to image.c Jiri Slaby
2010-06-25 13:55 ` Rafael J. Wysocki
2010-06-25 13:55 ` Rafael J. Wysocki
2010-06-02 8:52 ` Jiri Slaby
2010-06-02 11:40 ` [PATCH 1/9] PM / Hibernate: swap, switch to hibernate_io_handle Nigel Cunningham
2010-06-02 11:40 ` Nigel Cunningham
2010-06-02 12:37 ` [linux-pm] " Nigel Cunningham
2010-06-02 12:37 ` Nigel Cunningham
2010-06-10 13:55 ` Pavel Machek
2010-06-10 13:55 ` Pavel Machek
2010-06-21 15:23 ` Jiri Slaby
2010-06-21 15:23 ` Jiri Slaby
2010-07-18 12:36 ` Pavel Machek
2010-07-18 12:36 ` Pavel Machek
2010-06-11 9:46 ` Nigel Cunningham [this message]
2010-06-21 15:21 ` Jiri Slaby
2010-06-21 15:21 ` [linux-pm] " Jiri Slaby
2010-06-21 21:58 ` Nigel Cunningham
2010-06-25 14:00 ` Rafael J. Wysocki
2010-06-25 14:00 ` [linux-pm] " Rafael J. Wysocki
2010-06-21 21:58 ` Nigel Cunningham
2010-06-11 9:46 ` Nigel Cunningham
2010-06-24 15:20 ` Rafael J. Wysocki
2010-06-24 15:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1205DC.1080200@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.