From: Jens Axboe <jaxboe@fusionio.com>
To: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Cc: fio@vger.kernel.org
Subject: Re: weird error check for aio_cancel
Date: Fri, 11 Jun 2010 14:55:13 +0200 [thread overview]
Message-ID: <4C123231.2090505@fusionio.com> (raw)
In-Reply-To: <4C11E372.6070401@fusionio.com>
On 2010-06-11 09:19, Jens Axboe wrote:
> On 2010-06-11 06:33, YAMAMOTO Takashi wrote:
>> hi,
>>
>> please look at the following patch.
>>
>> YAMAMOTO Takashi
>>
>> Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
>>
>> commit e7aa7a65700932fe68d96015c06e6e1b1ecea0da
>> Author: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
>> Date: Fri Jun 11 12:32:42 2010 +0900
>>
>> fix a weird check of the return value of aio_cancel.
>>
>> i don't know what this 1 means in the first place but at least
>> it isn't portable. instead, check if the i/o has already
>> completed. (AIO_ALLDONE)
>
> You are right, that looks like a genuine bug. The last case of
> AIO_NOTCANCELLED should be ok, the caller should use normal completions
> to reap the remainders.
>
> I'll apply this.
BTW, since you are on NetBSD, have you noticed any problems with the
performance of aio with posixaio there? I have a report that it doesn't
work particularly fast on FreeBSD, at least it isn't able to saturate a
fast device like a small test app using posixaio would. That sounds like
a bug and I'm going to look into it, just wondering if you have seen
anything to that extent in your testing.
--
Jens Axboe
prev parent reply other threads:[~2010-06-11 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100611043346.3B7A771AC5@kuma.localdomain>
2010-06-11 7:19 ` weird error check for aio_cancel Jens Axboe
2010-06-11 12:55 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C123231.2090505@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.