From: Eric Sandeen <sandeen@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] quota: don't disable accounting with quotaoff
Date: Fri, 11 Jun 2010 17:09:14 -0500 [thread overview]
Message-ID: <4C12B40A.2070405@redhat.com> (raw)
The quotaon(8) man page says:
NOTES ON XFS FILESYSTEMS
...
To turn off quota limit enforcement on any XFS filesys-
tem, first make sure that quota accounting and enforce-
ment are both turned on using repquota -v filesystem.
Then, use quotaoff -v filesystem to disable limit
enforcement. This may be done while the filesystem is
mounted.
Turning on quota limit enforcement on an XFS filesystem
is achieved using quotaon -v filesystem. This may be
done while the filesystem is mounted
however, quotaoff turns off both enforcement -and- accounting,
and then quotaon fails.
If the manpage describes the intended behavior, then I think the
following patch is needed.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
--- quota-tools/quotaon_xfs.c 2010-01-05 10:39:54.000000000 -0500
+++ quota-tools-mine/quotaon_xfs.c 2010-06-11 17:45:12.000000000 -0400
@@ -208,10 +208,9 @@
}
#endif /* XFS_ROOTHACK */
- if (xarg == NULL) { /* both acct & enfd on/off */
- xopts |= (type == USRQUOTA) ?
- (XFS_QUOTA_UDQ_ACCT | XFS_QUOTA_UDQ_ENFD) :
- (XFS_QUOTA_GDQ_ACCT | XFS_QUOTA_GDQ_ENFD);
+ if (xarg == NULL) { /* only enfd on/off */
+ xopts |= (type == USRQUOTA) ? XFS_QUOTA_UDQ_ENFD :
+ XFS_QUOTA_GDQ_ENFD;
err = xfs_onoff((char *)dev, type, flags, roothack, xopts);
}
else if (strcmp(xarg, "account") == 0) {
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-06-11 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 22:09 Eric Sandeen [this message]
2010-06-14 10:10 ` [PATCH] quota: don't disable accounting with quotaoff Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C12B40A.2070405@redhat.com \
--to=sandeen@redhat.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.