From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44618 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ONPly-0002QV-Gd
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 08:25:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ONPlx-0003H6-Mo
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 08:25:14 -0400
Received: from fmmailgate03.web.de ([217.72.192.234]:38559)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ONPlx-0003Gt-CP
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 08:25:13 -0400
Message-ID: <4C137CA6.1020808@web.de>
Date: Sat, 12 Jun 2010 14:25:10 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak
	in create_config
References: <4C12A375.6050201@web.de> <20100612115557.GK3008@ohm.aurel32.net>
In-Reply-To: <20100612115557.GK3008@ohm.aurel32.net>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigD7309E5D884BAAD1F8B5A51E"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD7309E5D884BAAD1F8B5A51E
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Aurelien Jarno wrote:
> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Only match on true dir variable assignments, avoid generating garbage
>> due to the "# Configured with: ..." line which may contain "*dir=3D" a=
s
>> well.
>=20
> Wouldn't it be better to skip all lines starting with '#', as this
> problem might happen again after some more changes?
>=20
> Or maybe we should do both.

This is what the patch (implicitly) does.

Jan

>=20
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  create_config |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/create_config b/create_config
>> index 23c0cd5..0098e68 100755
>> --- a/create_config
>> +++ b/create_config
>> @@ -13,7 +13,7 @@ case $line in
>>      pkgversion=3D${line#*=3D}
>>      echo "#define QEMU_PKGVERSION \"$pkgversion\""
>>      ;;
>> - prefix=3D* | *dir=3D*) # directory configuration
>> + prefix=3D* | [a-z]*dir=3D*) # directory configuration
>>      name=3D${line%=3D*}
>>      value=3D${line#*=3D}
>>      define_name=3D`echo $name | tr '[:lower:]' '[:upper:]'`
>>
>>
>=20



--------------enigD7309E5D884BAAD1F8B5A51E
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkwTfKYACgkQitSsb3rl5xSApACfU/agXGxJvFvq11HYxEDEUKGh
ZlsAoMio6ulZ7BMjROxiraSloFpN2DRn
=sV3a
-----END PGP SIGNATURE-----

--------------enigD7309E5D884BAAD1F8B5A51E--