From: Paolo Bonzini <bonzini@gnu.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor)
Date: Sat, 12 Jun 2010 19:16:17 +0200 [thread overview]
Message-ID: <4C13C0E1.3070707@gnu.org> (raw)
In-Reply-To: <20100612163946.GD5657@burratino>
On 06/12/2010 06:39 PM, Jonathan Nieder wrote:
> From: Johannes Schindelin<johannes.schindelin@gmx.de>
>
> Suppose you want to edit all files that contain a specific search term.
> Of course, you can do something totally trivial such as
>
> git grep -z -e<term> | xargs -0r vi +/<term>
>
> but maybe you are happy that the same will be achieved by
>
> git grep -Ovi<term>
>
> now.
Ah, I had missed that the argument was optional. I think that optional
arguments are slightly frowned upon for POSIX utilities, because they're
a bit different. In fact, I think the only one is -i in sed (and BSD
sed instead makes it mandatory...). Personally I have no problem with
making -O in GNU grep optional too, I'll see what the other maintainers say.
Acked-by: Paolo Bonzini <bonzini@gnu.org>
Paolo
next prev parent reply other threads:[~2010-06-12 17:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 0:51 [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Jonathan Nieder
2010-06-05 0:53 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-05 1:40 ` Jonathan Nieder
2010-06-05 0:55 ` [PATCH 2/2] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-05 16:11 ` [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12 7:55 ` Jonathan Nieder
2010-06-12 9:46 ` Johannes Schindelin
2010-06-12 16:29 ` [PATCH v3 0/4] " Jonathan Nieder
2010-06-12 16:31 ` [PATCH 1/4] grep: refactor grep_objects loop into its own function Jonathan Nieder
2010-06-12 16:32 ` [PATCH 2/4] Unify code paths of threaded greps Jonathan Nieder
2010-06-12 16:36 ` [PATCH 3/4] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-12 16:39 ` [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-12 17:16 ` Paolo Bonzini [this message]
2010-06-13 16:35 ` Junio C Hamano
2010-06-13 17:04 ` Paolo Bonzini
2010-06-14 6:31 ` Jonathan Nieder
2010-06-12 21:36 ` [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12 22:12 ` Jonathan Nieder
2010-06-12 11:38 ` [PATCH v2 0/2] " Paolo Bonzini
2010-06-12 14:50 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C13C0E1.3070707@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.