From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ONpVb-0003cY-GE for mharc-grub-devel@gnu.org; Sun, 13 Jun 2010 11:54:03 -0400 Received: from [140.186.70.92] (port=49206 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONpVT-0003YC-NH for grub-devel@gnu.org; Sun, 13 Jun 2010 11:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONpV7-0008Bf-T2 for grub-devel@gnu.org; Sun, 13 Jun 2010 11:53:35 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:60115) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONpV7-0008AH-Oz for grub-devel@gnu.org; Sun, 13 Jun 2010 11:53:33 -0400 Received: by wyf28 with SMTP id 28so3200336wyf.0 for ; Sun, 13 Jun 2010 08:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=vq7Ibvf/F1TXWuf3TKUcCh9qbrbZ9uaRJg7ou90yOvY=; b=Spg0aX0nwU/K5Gnklt8gxwoF4spXloPdVvG7lSZUcUUhEqUynrhSIxR8NprjT1pJmY 5GP2ufPGlXwtpZWR5LAGgKcyxMiqVYfStz/GOgz+MFy0OxZ0nk1u5hp+kvqrmthHOJi4 WSbP7k8SO14TwLsSe0VvPSih3jomUQE/sr8Vo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=CtTbq07ZLuqwRYYU2T3kDU6qwoJUTGspc79DsSPWuMTkCTTuJL6ONYUpbeWl68S94m 24jMxFHAbs3yrhKJu/peOJwLKlQzuSNnG7Pdh+cxYWj1hETgPcLbvqApF3udeceMoal7 LDlV4QOpZHp+C3eCg0bu2h2jOg7M56s9Znkuc= Received: by 10.227.127.68 with SMTP id f4mr4591747wbs.44.1276444404089; Sun, 13 Jun 2010 08:53:24 -0700 (PDT) Received: from [192.168.1.50] ([88.160.112.182]) by mx.google.com with ESMTPS id n31sm28766325wba.3.2010.06.13.08.53.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 13 Jun 2010 08:53:23 -0700 (PDT) Message-ID: <4C14FEFA.2070209@gmail.com> Date: Sun, 13 Jun 2010 17:53:30 +0200 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <20100613104811.GM21862@riva.ucam.org> In-Reply-To: <20100613104811.GM21862@riva.ucam.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix grub-probe partition naming on FreeBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jun 2010 15:54:02 -0000 Hi Colin, > The following patch is aimed at fixing this Debian bug: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585068 > > I've tested it on Debian GNU/kFreeBSD and it seems to be producing sensible > output now. In another thread [1], it was observed that offsets are not absolute in FreeBSD disklabels, whereas they are absolute in NetBSD disklabels. I believe that find_partition_start is supposed to return absolute offsets. Does DIOCGDINFO convert the on-disk label into absolute offsets on FreeBSD? > The one glitch is that if you ask it to probe /dev/ad0s1a, it returns > (hd0,msdos1) rather than (hd0,msdos1,bsd1): this is because both /dev/ad0s1 > and /dev/ad0s1a have the same start sector, and it just uses the first one > it finds. When I set prefix to (hd0,msdos1)/boot/grub, GRUB can read from > that perfectly well, so can I ignore this glitch on the basis that it > doesn't cause a practical problem? We get a similar behavior on NetBSD. As I mentioned in [2], this may have an impact when the kernel is (a) loaded with the multiboot protocol, and (b) relies on the MBI boot_device field to find its root -- which it shouldn't anyway, so it's not a big deal. I am not aware of other impacts. I know that hybrid msdos+gpt are not recommended, but, for the record, I guess that another glitch could happen if /dev/ad0s1X (msdos) and /dev/ad0p1Y (gpt) are actually the same partition: grub-probe would return the same answer for both, thus ignoring the user's desire to use a specific partitioning scheme. I believe that such a partitioning is supported by FreeBSD, but I may be wrong (please tell me if so), I did not test this myself. Grégoire [1] http://lists.gnu.org/archive/html/grub-devel/2010-05/msg00065.html [2] http://lists.gnu.org/archive/html/grub-devel/2010-06/msg00075.html