All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Yang, Bo" <Bo.Yang@lsi.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: megaraid_sas locks down frame count to 8
Date: Mon, 14 Jun 2010 16:30:49 +0200	[thread overview]
Message-ID: <4C163D19.2030905@suse.de> (raw)

Hi all,

we have this bit in drivers/scsi/megaraid/megaraid_sas.c:799

	if (frame_count > 7)
		frame_count = 8;

which is supposed to report the number of frames required
to handle the passed in sg list.
This results in a nice memory scribble if we pass in a
large enough sg list, as the sg list contents will then
written in the memory area for the next frame.

Any comments here?

If it were me I would just remove that check, but
then LSI might have a valid reason for doing so.

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2010-06-14 14:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C163D19.2030905@suse.de \
    --to=hare@suse.de \
    --cc=Bo.Yang@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.