From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: Allow use headers in C++.
Date: Tue, 15 Jun 2010 13:50:11 +0200 [thread overview]
Message-ID: <4C1768F3.7010305@redhat.com> (raw)
In-Reply-To: <20100615114339.GA17838@redhat.com>
On 06/15/2010 01:43 PM, Mike Snitzer wrote:
> On Mon, Jun 14 2010 at 12:20pm -0400,
> Milan Broz <mbroz@redhat.com> wrote:
>
>> Remove C++ private keyword from header.
> ...
>> diff --git a/libdm/libdm-report.c b/libdm/libdm-report.c
>> index e13115a..2b044b5 100644
>> --- a/libdm/libdm-report.c
>> +++ b/libdm/libdm-report.c
>> @@ -566,7 +566,7 @@ struct dm_report *dm_report_init(uint32_t *report_types,
>> const char *output_separator,
>> uint32_t output_flags,
>> const char *sort_keys,
>> - void *private)
>> + void *private_data)
>> {
>> struct dm_report *rh;
>> const struct dm_report_object_type *type;
>> @@ -588,7 +588,7 @@ struct dm_report *dm_report_init(uint32_t *report_types,
>> rh->separator = output_separator;
>> rh->fields = fields;
>> rh->types = types;
>> - rh->private = private;
>> + rh->private = private_data;
>>
>> rh->flags |= output_flags & DM_REPORT_OUTPUT_MASK;
>
> Should struct dm_report's "private" be renamed too?
Not needed, that's not part of external API/ABI but internal to library.
(There are more such conflicting names, but these are not problem in compilation,
because this is always compiled in C only.)
Milan
next prev parent reply other threads:[~2010-06-15 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 16:20 [PATCH] Allow use headers in C++ Milan Broz
2010-06-14 19:27 ` ben scott
2010-06-15 11:43 ` Mike Snitzer
2010-06-15 11:50 ` Milan Broz [this message]
2010-06-16 12:14 ` [PATCH] " Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1768F3.7010305@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.