Re: [Qemu-devel] [CFR 4/10] command

[Anthony Liguori <anthony@codemonkey.ws>]

On 06/15/2010 11:30 AM, Anthony Liguori wrote:
> change
> ------
>
> Change a removable medium or VNC configuration.
>    

I think this command is awkward and should be split into a change-media 
and change-vnc-password command.

> Arguments:
>
> - "device": device name (json-string)
> - "target": filename or item (json-string)
> - "arg": additional argument (json-string, optional)
>    

For change-media:

1) what happens if the drive does not support removable media?
2) what happens if the drive is locked?
3) what happens if media is not currently present?
4) what if I want to pass additional options to target like format=raw?
5) is the media change immediately present to the guest upon return of 
the command?

For change-vnc-password:

1) what if VNC is not in use?
2) what if I don't have vnc authentication enabled?
3) does changing the password have any affect on existing sessions?
4) is a new password required immediately after the command completes?

Regards,

Anthony Liguori

> Examples:
>
> 1. Change a removable medium
>
> ->  { "execute": "change",
>               "arguments": { "device": "ide1-cd0",
>                              "target": "/srv/images/Fedora-12-x86_64-DVD.iso" } }
> <- { "return": {} }
>
> 2. Change VNC password
>
> ->  { "execute": "change",
>               "arguments": { "device": "vnc", "target": "password",
>                              "arg": "foobar1" } }
> <- { "return": {} }
>
>
>