All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH, RFC] Add linux-libc-headers-native, make it default dep for native
Date: Tue, 15 Jun 2010 10:48:36 -0700	[thread overview]
Message-ID: <4C17BCF4.30109@mentor.com> (raw)
In-Reply-To: <4C0D498A.4030709@mentor.com>

Tom Rini wrote:
> On some host distributions the provided linux kernel headers are too old
> to compile utilities we need[1].  Given that we need these utilities to
> run things on the target the best solution is to provide
> linux-libc-headers-native.  Rather than get things into an inconsistent
> state, we make linux-libc-headers-native be a default dependency.
> 
> [1]: A prime example of this would be mtd-utils-native and UBI

ping?  The summary of the feedback, I believe would be:
- Can we just make this opt-in for distros that need it?
- Can we easily opt out if we don't?

For the second, yes, ASSUME_PROVIDED still works.  For the first, I'd 
argue that doing so is a lot harder (at least without some additional 
infrastructure and reliance on other external tools) than just adding 
another early package.

So, yay or nay?

> 
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index e0f9184..e26a45e 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -75,6 +75,12 @@ def base_dep_prepend(d):
>          if (bb.data.getVar('HOST_SYS', d, 1) !=
>                   bb.data.getVar('BUILD_SYS', d, 1)):
>              deps += " virtual/${TARGET_PREFIX}gcc virtual/libc "
> +        elif bb.data.inherits_class('native', d) and \
> +                bb.data.getVar('PN', d, True) not in \
> +                ("linux-libc-headers-native", "quilt-native",
> +                 "unifdef-native", "shasum-native",
> +                 "stagemanager-native", "coreutils-native"):
> +            deps += " linux-libc-headers-native"
>      return deps
> 
>  DEPENDS_prepend="${@base_dep_prepend(d)} "
> diff --git a/recipes/linux-libc-headers/linux-libc-headers.inc
> b/recipes/linux-libc-headers/linux-libc-headers.inc
> index 0487e65..0b0d05a 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers.inc
> +++ b/recipes/linux-libc-headers/linux-libc-headers.inc
> @@ -1,7 +1,8 @@
>  DESCRIPTION = "Sanitized set of 2.6 kernel headers for the C library's
> use."
>  SECTION = "devel"
>  LICENSE = "GPL"
> +NATIVE_INSTALL_WORKS = "1"
> +BBCLASSEXTEND = "native"
> 
>  RDEPENDS_${PN}-dev = ""
>  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPV})"
> -
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb
> b/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb
> index b66e768..0a1159a 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.7.0.bb
> @@ -1,6 +1,7 @@
>  require linux-libc-headers.inc
> 
>  INHIBIT_DEFAULT_DEPS = "1"
> +NATIVE_INSTALL_WORKS = "0"
>  PR = "r4"
>  # NOTE: no need to package these headers, since the c library includes
> them.
>  PACKAGES = ""
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb
> b/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb
> index 4893cab..6cbd8ba 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.8.1.bb
> @@ -1,5 +1,6 @@
>  require linux-libc-headers.inc
> 
> +NATIVE_INSTALL_WORKS = "0"
>  HOMEPAGE = "http://ep09.pld-linux.org/~mmazur/linux-libc-headers/"
>  # license note from the package:
>  #   Linux-libc-headers are derived from linux kernel headers. For
> license of a


-- 
Tom Rini
Mentor Graphics Corporation



  parent reply	other threads:[~2010-06-15 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 19:33 [PATCH, RFC] Add linux-libc-headers-native, make it default dep for native Tom Rini
2010-06-07 21:21 ` Khem Raj
2010-06-07 21:31   ` Chris Larson
2010-06-08  0:19     ` Khem Raj
2010-06-08  6:36 ` Frans Meulenbroeks
2010-06-08 14:04   ` Khem Raj
2010-06-08 14:36   ` Tom Rini
2010-06-09  6:45     ` Frans Meulenbroeks
2010-06-09 14:51       ` Tom Rini
2010-06-15 17:48 ` Tom Rini [this message]
2010-06-15 23:30   ` Leon Woestenberg
2010-06-16  2:06     ` Tom Rini
2010-06-16  7:36       ` Frans Meulenbroeks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C17BCF4.30109@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.