All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v2] gpio_led: add gpio_request to __led_init
Date: Tue, 15 Jun 2010 21:29:58 -0400	[thread overview]
Message-ID: <4C182916.9050202@psyent.com> (raw)
In-Reply-To: <1276061566-27514-1-git-send-email-thomas@wytron.com.tw>

Applied to: git://git.denx.de/u-boot-nios.git next
Thanks,
--Scott

Thomas Chou wrote:
> This patch adds the gpio usage request. The polarity is changed to
> positive as suggested by Mike Frysinger.
> 
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> v2: fix typo, change led polarity
> 
>  drivers/misc/gpio_led.c |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c
> index acd6a90..3fedddc 100644
> --- a/drivers/misc/gpio_led.c
> +++ b/drivers/misc/gpio_led.c
> @@ -2,26 +2,22 @@
>   * Status LED driver based on GPIO access conventions of Linux
>   *
>   * Copyright (C) 2010 Thomas Chou <thomas@wytron.com.tw>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> + * Licensed under the GPL-2 or later.
>   */
>  
>  #include <common.h>
>  #include <status_led.h>
>  #include <asm/gpio.h>
>  
> -/* assume led is active low */
> -
>  void __led_init(led_id_t mask, int state)
>  {
> -	gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1);
> +	gpio_request(mask, "gpio_led");
> +	gpio_direction_output(mask, state == STATUS_LED_ON);
>  }
>  
>  void __led_set(led_id_t mask, int state)
>  {
> -	gpio_set_value(mask, (state == STATUS_LED_ON) ? 0 : 1);
> +	gpio_set_value(mask, state == STATUS_LED_ON);
>  }
>  
>  void __led_toggle(led_id_t mask)

  reply	other threads:[~2010-06-16  1:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09  1:51 [U-Boot] [PATCH 1/2] nios2: add gpio_request Thomas Chou
2010-06-09  1:51 ` [U-Boot] [PATCH 2/2] gpio_led: add gpio_request to __led_init Thomas Chou
2010-06-09  4:25   ` Mike Frysinger
2010-06-09  5:32     ` [U-Boot] [PATCH 2/2 v2] " Thomas Chou
2010-06-16  1:29       ` Scott McNutt [this message]
2010-07-05 14:31         ` Thomas Chou
2010-06-09  5:41     ` [U-Boot] [PATCH 2/2] " Thomas Chou
2010-06-16  1:29 ` [U-Boot] [PATCH 1/2] nios2: add gpio_request Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C182916.9050202@psyent.com \
    --to=smcnutt@psyent.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.