From: Kevin Wolf <kwolf@redhat.com>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices
Date: Wed, 16 Jun 2010 15:15:11 +0200 [thread overview]
Message-ID: <4C18CE5F.3090402@redhat.com> (raw)
In-Reply-To: <AANLkTikVYbW4Bhqu9-8lAm66BuXWVWXf_nlzXNB0CFUC@mail.gmail.com>
Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho:
> On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>>
>> If the human monitor was exactly what its name says, I'd happily apply
>> this one (though I think it should be made clear from which image the VM
>> state would be loaded). However, it isn't and I'm not sure if this
>> wouldn't break libvirt. Dan, can you help?
>>
>
> I didn't mention in the commit, but I've looked at libvirt's source
> and it is not using 'info snapshots' AFAIK.
Anthony, Dan, are you okay with the change then?
> At the present time, the VM state is always saved in the first block
> device that supports snapshots. I could update the patch to make it
> clear on the output somehow.
Would be nice to make it clear. Something like this maybe:
Snapshot list from ide0-hd0 (VM state image):
[...]
Kevin
next prev parent reply other threads:[~2010-06-16 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 1:53 [Qemu-devel] [PATCH] monitor: Really show snapshot information about all devices Miguel Di Ciurcio Filho
2010-06-16 12:40 ` [Qemu-devel] " Kevin Wolf
2010-06-16 12:59 ` Miguel Di Ciurcio Filho
2010-06-16 13:15 ` Kevin Wolf [this message]
[not found] ` <20100616152249.GB2835@localhost.localdomain>
2010-06-16 15:32 ` Kevin Wolf
[not found] ` <20100616155710.GC2835@localhost.localdomain>
2010-06-17 7:48 ` Kevin Wolf
2010-06-16 22:12 ` Miguel Di Ciurcio Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C18CE5F.3090402@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.